Re: [dpdk-dev] [PATCH 1/2] net/mlx5: add kernel version function

2018-02-18 Thread Nélio Laranjeiro
On Fri, Feb 16, 2018 at 10:03:04AM -0800, Stephen Hemminger wrote: > On Thu, 15 Feb 2018 09:47:27 +0100 > Nelio Laranjeiro wrote: > > > Use a function to retrieve the version of the kernel. > > > > Signed-off-by: Nelio Laranjeiro > > This type of logic will run into problems with Enterprise an

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: add kernel version function

2018-02-16 Thread Stephen Hemminger
On Thu, 15 Feb 2018 09:47:27 +0100 Nelio Laranjeiro wrote: > Use a function to retrieve the version of the kernel. > > Signed-off-by: Nelio Laranjeiro This type of logic will run into problems with Enterprise and vendor kernels. What about users using older kernels with OFED? What about case w

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: add kernel version function

2018-02-16 Thread Adrien Mazarguil
On Thu, Feb 15, 2018 at 09:47:27AM +0100, Nelio Laranjeiro wrote: > Use a function to retrieve the version of the kernel. > > Signed-off-by: Nelio Laranjeiro A couple of nits, please see below. > --- > drivers/net/mlx5/mlx5_ethdev.c | 13 + > drivers/net/mlx5/mlx5_utils.h | 26 +++

[dpdk-dev] [PATCH 1/2] net/mlx5: add kernel version function

2018-02-15 Thread Nelio Laranjeiro
Use a function to retrieve the version of the kernel. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_ethdev.c | 13 + drivers/net/mlx5/mlx5_utils.h | 26 ++ 2 files changed, 31 insertions(+), 8 deletions(-) diff --git a/drivers/net/mlx5/mlx5_ethde