Re: [dpdk-dev] [PATCH 1/2] examples/ethtool: remove query of default config

2019-03-20 Thread Thomas Monjalon
20/03/2019 14:56, Ferruh Yigit: > On 3/20/2019 1:51 PM, Thomas Monjalon wrote: > > 20/03/2019 14:46, Ferruh Yigit: > >> Applied to dpdk-next-net/master, thanks. > >> > >> (only this patch merged, not series. Other patch seems waiting for > >> comment.) > > > > Applying half of patchset makes trac

Re: [dpdk-dev] [PATCH 1/2] examples/ethtool: remove query of default config

2019-03-20 Thread Ferruh Yigit
On 3/20/2019 1:51 PM, Thomas Monjalon wrote: > 20/03/2019 14:46, Ferruh Yigit: >> Applied to dpdk-next-net/master, thanks. >> >> (only this patch merged, not series. Other patch seems waiting for comment.) > > Applying half of patchset makes tracking of patches less obvious. > I prefer we avoid su

Re: [dpdk-dev] [PATCH 1/2] examples/ethtool: remove query of default config

2019-03-20 Thread Thomas Monjalon
20/03/2019 14:46, Ferruh Yigit: > Applied to dpdk-next-net/master, thanks. > > (only this patch merged, not series. Other patch seems waiting for comment.) Applying half of patchset makes tracking of patches less obvious. I prefer we avoid such practice.

Re: [dpdk-dev] [PATCH 1/2] examples/ethtool: remove query of default config

2019-03-20 Thread Ferruh Yigit
On 3/13/2019 5:41 PM, Rami Rosen wrote: > On Wed, Mar 13, 2019 at 11:09:09AM +0100, Thomas Monjalon wrote: >>> The default config is used if the setup parameter is NULL. >>> No need to query the default config with rte_eth_dev_info_get(). >>> The function call will be removed with another useless i

Re: [dpdk-dev] [PATCH 1/2] examples/ethtool: remove query of default config

2019-03-13 Thread Rami Rosen
On Wed, Mar 13, 2019 at 11:09:09AM +0100, Thomas Monjalon wrote: > > The default config is used if the setup parameter is NULL. > > No need to query the default config with rte_eth_dev_info_get(). > > The function call will be removed with another useless info. > > > > Signed-off-by: Thomas Monjalo

Re: [dpdk-dev] [PATCH 1/2] examples/ethtool: remove query of default config

2019-03-13 Thread Bruce Richardson
On Wed, Mar 13, 2019 at 11:09:09AM +0100, Thomas Monjalon wrote: > The default config is used if the setup parameter is NULL. > No need to query the default config with rte_eth_dev_info_get(). > The function call will be removed with another useless info. > > Signed-off-by: Thomas Monjalon Acked

[dpdk-dev] [PATCH 1/2] examples/ethtool: remove query of default config

2019-03-13 Thread Thomas Monjalon
The default config is used if the setup parameter is NULL. No need to query the default config with rte_eth_dev_info_get(). The function call will be removed with another useless info. Signed-off-by: Thomas Monjalon --- examples/ethtool/ethtool-app/main.c | 4 +--- 1 file changed, 1 insertion(+)