Re: [dpdk-dev] [PATCH 1/2] ethdev: fix name index in xstats Api

2017-01-03 Thread Remy Horton
Been away, hence the somewhat late review.. On 16/12/2016 09:44, Olivier Matz wrote: [..] Today, each 'id' returned by rte_eth_xstats_get() is equal to the index in the returned array, making this value useless. It also prevents a driver from having different indexes for names and value, like in

[dpdk-dev] [PATCH 1/2] ethdev: fix name index in xstats Api

2016-12-16 Thread Olivier Matz
The function rte_eth_xstats_get() return an array of tuples (id, value). The value is the statistic counter, while the id references a name in the array returned by rte_eth_xstats_get_name(). Today, each 'id' returned by rte_eth_xstats_get() is equal to the index in the returned array, making this