Re: [dpdk-dev] [PATCH 1/2] ethdev: announce flow API action PORT_ID changes

2021-08-02 Thread Andrew Rybchenko
On 8/2/21 6:49 PM, Ilya Maximets wrote: On 8/1/21 12:22 PM, Andrew Rybchenko wrote: By its very name, action PORT_ID means that packets hit an ethdev with the given DPDK port ID. At least the current comments don't state the opposite. That said, since port representors had been adopted, applicat

Re: [dpdk-dev] [PATCH 1/2] ethdev: announce flow API action PORT_ID changes

2021-08-02 Thread Ilya Maximets
On 8/1/21 12:22 PM, Andrew Rybchenko wrote: > By its very name, action PORT_ID means that packets hit an ethdev with the > given DPDK port ID. At least the current comments don't state the opposite. > That said, since port representors had been adopted, applications like OvS > have been misusing th

Re: [dpdk-dev] [PATCH 1/2] ethdev: announce flow API action PORT_ID changes

2021-08-02 Thread Ori Kam
Acked-by: Ori Kam Thanks, Ori

Re: [dpdk-dev] [PATCH 1/2] ethdev: announce flow API action PORT_ID changes

2021-08-02 Thread Ori Kam
> -Original Message- > From: Andrew Rybchenko > > On 8/1/21 7:13 PM, Ori Kam wrote: > > Hi Andrew, > > > >> -Original Message- > >> From: Andrew Rybchenko > >> Sent: Sunday, August 1, 2021 4:24 PM > >> Subject: Re: [PATCH 1/2] ethdev: announce flow API action PORT_ID > >> chan

Re: [dpdk-dev] [PATCH 1/2] ethdev: announce flow API action PORT_ID changes

2021-08-02 Thread Andrew Rybchenko
Hi Ori, On 8/2/21 10:28 AM, Ori Kam wrote: -Original Message- From: Andrew Rybchenko On 8/1/21 7:13 PM, Ori Kam wrote: Hi Andrew, -Original Message- From: Andrew Rybchenko Sent: Sunday, August 1, 2021 4:24 PM Subject: Re: [PATCH 1/2] ethdev: announce flow API action PORT_I

Re: [dpdk-dev] [PATCH 1/2] ethdev: announce flow API action PORT_ID changes

2021-08-01 Thread Ori Kam
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Sunday, August 1, 2021 4:24 PM > Subject: Re: [PATCH 1/2] ethdev: announce flow API action PORT_ID changes > > On 8/1/21 3:56 PM, Ori Kam wrote: > > Hi Andrew, > > > >> -Original Message- > >> From: Andrew Rybchenk

Re: [dpdk-dev] [PATCH 1/2] ethdev: announce flow API action PORT_ID changes

2021-08-01 Thread Andrew Rybchenko
On 8/1/21 7:13 PM, Ori Kam wrote: Hi Andrew, -Original Message- From: Andrew Rybchenko Sent: Sunday, August 1, 2021 4:24 PM Subject: Re: [PATCH 1/2] ethdev: announce flow API action PORT_ID changes On 8/1/21 3:56 PM, Ori Kam wrote: Hi Andrew, -Original Message- From: Andre

Re: [dpdk-dev] [PATCH 1/2] ethdev: announce flow API action PORT_ID changes

2021-08-01 Thread Ori Kam
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Sunday, August 1, 2021 3:44 PM > Subject: Re: [PATCH 1/2] ethdev: announce flow API action PORT_ID changes > > Hi Ori, > > On 8/1/21 3:23 PM, Ori Kam wrote: > > Hi Andrew, > > > > I think before we can change the API we mu

Re: [dpdk-dev] [PATCH 1/2] ethdev: announce flow API action PORT_ID changes

2021-08-01 Thread Ori Kam
Hi Andrew, I think before we can change the API we must agree on the meaning of representor. PSB more comments > -Original Message- > From: Andrew Rybchenko > Sent: Sunday, August 1, 2021 3:04 PM > To: Eli Britstein ; NBU-Contact-Thomas Monjalon > ; Ferruh Yigit ; Ori Kam > > Cc: dev@

Re: [dpdk-dev] [PATCH 1/2] ethdev: announce flow API action PORT_ID changes

2021-08-01 Thread Eli Britstein
On 8/1/2021 1:22 PM, Andrew Rybchenko wrote: External email: Use caution opening links or attachments By its very name, action PORT_ID means that packets hit an ethdev with the given DPDK port ID. At least the current comments don't state the opposite. That said, since port representors had b

Re: [dpdk-dev] [PATCH 1/2] ethdev: announce flow API action PORT_ID changes

2021-08-01 Thread Andrew Rybchenko
On 8/1/21 3:56 PM, Ori Kam wrote: Hi Andrew, -Original Message- From: Andrew Rybchenko Sent: Sunday, August 1, 2021 3:44 PM Subject: Re: [PATCH 1/2] ethdev: announce flow API action PORT_ID changes Hi Ori, On 8/1/21 3:23 PM, Ori Kam wrote: Hi Andrew, I think before we can change th

Re: [dpdk-dev] [PATCH 1/2] ethdev: announce flow API action PORT_ID changes

2021-08-01 Thread Andrew Rybchenko
Hi Ori, On 8/1/21 3:23 PM, Ori Kam wrote: Hi Andrew, I think before we can change the API we must agree on the meaning of representor. The question is not directly related to a representor definition. Just indirectly. PORT_ID action makes sense for non-representor ports as well. PSB more c

Re: [dpdk-dev] [PATCH 1/2] ethdev: announce flow API action PORT_ID changes

2021-08-01 Thread Andrew Rybchenko
On 8/1/21 1:57 PM, Eli Britstein wrote: On 8/1/2021 1:22 PM, Andrew Rybchenko wrote: External email: Use caution opening links or attachments By its very name, action PORT_ID means that packets hit an ethdev with the given DPDK port ID. At least the current comments don't state the opposite

[dpdk-dev] [PATCH 1/2] ethdev: announce flow API action PORT_ID changes

2021-08-01 Thread Andrew Rybchenko
By its very name, action PORT_ID means that packets hit an ethdev with the given DPDK port ID. At least the current comments don't state the opposite. That said, since port representors had been adopted, applications like OvS have been misusing the action. They misread its purpose as sending packet