[dpdk-dev] [PATCH 1/2] eal: move plugin loading to eal/common

2015-10-21 Thread Panu Matilainen
On 10/21/2015 02:53 PM, Thomas Monjalon wrote: > 2015-10-21 12:15, Bruce Richardson: >> On Wed, Oct 21, 2015 at 01:09:24PM +0200, David Marchand wrote: >>> On Wed, Oct 21, 2015 at 12:54 PM, Panu Matilainen >>> wrote: Btw, returning an error here would change current behavior of dpdk load

[dpdk-dev] [PATCH 1/2] eal: move plugin loading to eal/common

2015-10-21 Thread Panu Matilainen
On 10/21/2015 01:15 PM, David Marchand wrote: > On Wed, Oct 21, 2015 at 10:29 AM, Panu Matilainen > wrote: > >> There's no good reason to limit plugins to Linux, make it available >> on FreeBSD too. Refactor the plugin code from Linux EAL to common >> helper functions, also check for potential err

[dpdk-dev] [PATCH 1/2] eal: move plugin loading to eal/common

2015-10-21 Thread Thomas Monjalon
2015-10-21 12:15, Bruce Richardson: > On Wed, Oct 21, 2015 at 01:09:24PM +0200, David Marchand wrote: > > On Wed, Oct 21, 2015 at 12:54 PM, Panu Matilainen > > wrote: > > > > > > Btw, returning an error here would change current behavior of dpdk loading > > >> drivers. > > >> Not sure we want this

[dpdk-dev] [PATCH 1/2] eal: move plugin loading to eal/common

2015-10-21 Thread David Marchand
On Wed, Oct 21, 2015 at 12:54 PM, Panu Matilainen wrote: > > Btw, returning an error here would change current behavior of dpdk loading >> drivers. >> Not sure we want this as people may rely on this loading not failing. >> > > Yeah, dpdk currently doesn't fail if you pass garbage to -d, which is

[dpdk-dev] [PATCH 1/2] eal: move plugin loading to eal/common

2015-10-21 Thread Bruce Richardson
On Wed, Oct 21, 2015 at 01:09:24PM +0200, David Marchand wrote: > On Wed, Oct 21, 2015 at 12:54 PM, Panu Matilainen > wrote: > > > > Btw, returning an error here would change current behavior of dpdk loading > >> drivers. > >> Not sure we want this as people may rely on this loading not failing. >

[dpdk-dev] [PATCH 1/2] eal: move plugin loading to eal/common

2015-10-21 Thread David Marchand
On Wed, Oct 21, 2015 at 10:29 AM, Panu Matilainen wrote: > There's no good reason to limit plugins to Linux, make it available > on FreeBSD too. Refactor the plugin code from Linux EAL to common > helper functions, also check for potential errors during initialization. > Not sure about this "pot

[dpdk-dev] [PATCH 1/2] eal: move plugin loading to eal/common

2015-10-21 Thread Panu Matilainen
There's no good reason to limit plugins to Linux, make it available on FreeBSD too. Refactor the plugin code from Linux EAL to common helper functions, also check for potential errors during initialization. Signed-off-by: Panu Matilainen --- lib/librte_eal/bsdapp/eal/eal.c| 3 ++ li