Re: [dpdk-dev] [PATCH 1/2] eal: add static endianness conversion macros

2017-06-08 Thread Thomas Monjalon
08/06/2017 11:14, Adrien Mazarguil: > On Wed, Jun 07, 2017 at 04:16:58PM +0200, Thomas Monjalon wrote: > > Hi, some comments below: > > > > 18/05/2017 12:14, Adrien Mazarguil: > > > +#define RTE_STATIC_BSWAP64(v) \ > > > + uint64_t)(v) & UINT64_C(0x00ff)) << 56) | \ > > > + (((uin

Re: [dpdk-dev] [PATCH 1/2] eal: add static endianness conversion macros

2017-06-08 Thread Adrien Mazarguil
On Wed, Jun 07, 2017 at 04:16:58PM +0200, Thomas Monjalon wrote: > Hi, some comments below: > > 18/05/2017 12:14, Adrien Mazarguil: > > These macros resolve to constant expressions that allow developers to > > perform endianness conversion on static/const objects, even outside of > > function scop

Re: [dpdk-dev] [PATCH 1/2] eal: add static endianness conversion macros

2017-06-07 Thread Thomas Monjalon
Hi, some comments below: 18/05/2017 12:14, Adrien Mazarguil: > These macros resolve to constant expressions that allow developers to > perform endianness conversion on static/const objects, even outside of > function scope as they do not translate to function calls. > > This is most useful for st

[dpdk-dev] [PATCH 1/2] eal: add static endianness conversion macros

2017-05-18 Thread Adrien Mazarguil
These macros resolve to constant expressions that allow developers to perform endianness conversion on static/const objects, even outside of function scope as they do not translate to function calls. This is most useful for static initializers and constant values (whenever it has to be performed a