Re: [dpdk-dev] [PATCH 1/2] eal/x86: use cpuid builtin

2017-08-24 Thread Sergio Gonzalez Monroy
On 23/08/2017 21:49, Thomas Monjalon wrote: Please could you explain why the asm code was used? I guess we were not aware that there was a builtin for it. Are you sure this builtin is implemented everywhere? Actually the builtin used in this patch is not supported in most CLANG version (j

Re: [dpdk-dev] [PATCH 1/2] eal/x86: use cpuid builtin

2017-08-23 Thread Thomas Monjalon
Please could you explain why the asm code was used? Are you sure this builtin is implemented everywhere?

[dpdk-dev] [PATCH 1/2] eal/x86: use cpuid builtin

2017-08-23 Thread Sergio Gonzalez Monroy
Signed-off-by: Sergio Gonzalez Monroy --- lib/librte_eal/common/arch/x86/rte_cpuflags.c | 41 +-- 1 file changed, 7 insertions(+), 34 deletions(-) diff --git a/lib/librte_eal/common/arch/x86/rte_cpuflags.c b/lib/librte_eal/common/arch/x86/rte_cpuflags.c index 0138257..67