Re: [dpdk-dev] [PATCH 1/2] baseband/fpga_5gnr_fec: fix segfaults with debug

2020-10-06 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, October 6, 2020 9:34 AM > To: Chautru, Nicolas ; dev@dpdk.org; > sta...@dpdk.org; t...@redhat.com > Subject: Re: [PATCH 1/2] baseband/fpga_5gnr_fec: fix segfaults with debug > > Hi Nicolas, > > On 10/6/20 6:14 PM,

Re: [dpdk-dev] [PATCH 1/2] baseband/fpga_5gnr_fec: fix segfaults with debug

2020-10-06 Thread Maxime Coquelin
Hi Nicolas, On 10/6/20 6:14 PM, Chautru, Nicolas wrote: > Thanks Maxime > I am not totally sure that this actually got broken in the very commit you > point to (I think that there was another pci generic commit which changed the > assumption when this pointer was set), but it doesn't harm to cha

Re: [dpdk-dev] [PATCH 1/2] baseband/fpga_5gnr_fec: fix segfaults with debug

2020-10-06 Thread Chautru, Nicolas
Thanks Maxime I am not totally sure that this actually got broken in the very commit you point to (I think that there was another pci generic commit which changed the assumption when this pointer was set), but it doesn't harm to change anyway for stable build. Note this is already like this in

[dpdk-dev] [PATCH 1/2] baseband/fpga_5gnr_fec: fix segfaults with debug

2020-10-06 Thread Maxime Coquelin
When RTE_LIBRTE_BBDEV_DEBUG is enabled, rte_device's driver pointer is dereferenced twice in fpga_5gnr_fec's probe callback. It causes a segmentation fault because this pointer is only assigned after probe callback call. This patch makes use of rte_pci_driver pointer instead. Fixes: 0b5927cbcba7