Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-09 Thread Jerin Jacob
On Mon, Nov 9, 2020 at 8:12 PM Thomas Monjalon wrote: > > 09/11/2020 15:08, Jerin Jacob: > > On Mon, Nov 9, 2020 at 7:32 PM Thomas Monjalon wrote: > > > 09/11/2020 14:35, Jerin Jacob: > > > > Are you facing the issue with 32bit? Could you share the steps to > > > > reproduce and gcc version? > >

Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-09 Thread Thomas Monjalon
09/11/2020 15:08, Jerin Jacob: > On Mon, Nov 9, 2020 at 7:32 PM Thomas Monjalon wrote: > > 09/11/2020 14:35, Jerin Jacob: > > > Are you facing the issue with 32bit? Could you share the steps to > > > reproduce and gcc version? > > > > Oh you're right, the issue was with 32-bit build, > > Thanks >

Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-09 Thread Jerin Jacob
On Mon, Nov 9, 2020 at 7:32 PM Thomas Monjalon wrote: > > 09/11/2020 14:35, Jerin Jacob: > > On Mon, Nov 9, 2020 at 6:29 PM Thomas Monjalon wrote: > > > > > > 09/11/2020 13:01, Jerin Jacob: > > > > Hi @Thomas Monjalon > > > > > > > > Any specific reason why you removed the static assert from octe

Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-09 Thread Thomas Monjalon
09/11/2020 14:35, Jerin Jacob: > On Mon, Nov 9, 2020 at 6:29 PM Thomas Monjalon wrote: > > > > 09/11/2020 13:01, Jerin Jacob: > > > Hi @Thomas Monjalon > > > > > > Any specific reason why you removed the static assert from octeontx2. > > > > I have a build failure when cross-compiling for octeontx

Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-09 Thread Jerin Jacob
On Mon, Nov 9, 2020 at 6:29 PM Thomas Monjalon wrote: > > 09/11/2020 13:01, Jerin Jacob: > > Hi @Thomas Monjalon > > > > Any specific reason why you removed the static assert from octeontx2. > > I have a build failure when cross-compiling for octeontx2. I am trying the below command, I am not abl

Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-09 Thread Thomas Monjalon
09/11/2020 13:01, Jerin Jacob: > Hi @Thomas Monjalon > > Any specific reason why you removed the static assert from octeontx2. I have a build failure when cross-compiling for octeontx2. > I am not able to compilation issue with that static assert. There is no issue when compiling for x86. > Th

Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-09 Thread Jerin Jacob
On Mon, Nov 9, 2020 at 3:17 PM Bruce Richardson wrote: > > On Mon, Nov 09, 2020 at 01:57:26PM +0530, Jerin Jacob wrote: > > On Mon, Nov 9, 2020 at 1:34 PM Thomas Monjalon wrote: > > > > > > 09/11/2020 06:18, Jerin Jacob: > > > > On Sun, Nov 8, 2020 at 2:03 AM Thomas Monjalon > > > > wrote: > >

Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-09 Thread Ananyev, Konstantin
> > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > Sent: Saturday, November 7, 2020 4:53 PM > > > > > > > > The mempool pointer in the mbuf struct is moved > > > > from the second to the first half. > > > > It should increase performance on most systems having 64-byte cache > > > >

Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-09 Thread Bruce Richardson
On Mon, Nov 09, 2020 at 10:33:41AM +, Ananyev, Konstantin wrote: > > > > On Sat, Nov 07, 2020 at 07:57:05PM +0100, Morten Brørup wrote: > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > Sent: Saturday, November 7, 2020 4:53 PM > > > > > > > > The mempool pointer in the mbuf s

Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-09 Thread Ananyev, Konstantin
> On Sat, Nov 07, 2020 at 07:57:05PM +0100, Morten Brørup wrote: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > Sent: Saturday, November 7, 2020 4:53 PM > > > > > > The mempool pointer in the mbuf struct is moved > > > from the second to the first half. > > > It should increase p

Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-09 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Monday, November 9, 2020 11:09 AM > > On Sat, Nov 07, 2020 at 07:57:05PM +0100, Morten Brørup wrote: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > Sent: Saturday, November 7, 2020 4:53 PM > > > > > > The mempool

Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-09 Thread Bruce Richardson
On Sat, Nov 07, 2020 at 07:57:05PM +0100, Morten Brørup wrote: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Saturday, November 7, 2020 4:53 PM > > > > The mempool pointer in the mbuf struct is moved > > from the second to the first half. > > It should increase performance on mo

Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-09 Thread Bruce Richardson
On Mon, Nov 09, 2020 at 01:57:26PM +0530, Jerin Jacob wrote: > On Mon, Nov 9, 2020 at 1:34 PM Thomas Monjalon wrote: > > > > 09/11/2020 06:18, Jerin Jacob: > > > On Sun, Nov 8, 2020 at 2:03 AM Thomas Monjalon > > > wrote: > > > > 07/11/2020 20:05, Jerin Jacob: > > > > > On Sun, Nov 8, 2020 at 12

Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-09 Thread Jerin Jacob
On Mon, Nov 9, 2020 at 1:34 PM Thomas Monjalon wrote: > > 09/11/2020 06:18, Jerin Jacob: > > On Sun, Nov 8, 2020 at 2:03 AM Thomas Monjalon wrote: > > > 07/11/2020 20:05, Jerin Jacob: > > > > On Sun, Nov 8, 2020 at 12:09 AM Thomas Monjalon > > > > wrote: > > > > > 07/11/2020 18:12, Jerin Jacob:

Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-09 Thread Morten Brørup
+CC techboard > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Monday, November 9, 2020 6:18 AM > > On Sun, Nov 8, 2020 at 2:03 AM Thomas Monjalon > wrote: > > > > 07/11/2020 20:05, Jerin Jacob: > > > On Sun, Nov 8, 2020 at 12:09 AM Thomas Monjalon > wrote: > > > > 07/11/2020 18:12, J

Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-09 Thread Thomas Monjalon
09/11/2020 06:18, Jerin Jacob: > On Sun, Nov 8, 2020 at 2:03 AM Thomas Monjalon wrote: > > 07/11/2020 20:05, Jerin Jacob: > > > On Sun, Nov 8, 2020 at 12:09 AM Thomas Monjalon > > > wrote: > > > > 07/11/2020 18:12, Jerin Jacob: > > > > > On Sat, Nov 7, 2020 at 10:04 PM Thomas Monjalon > > > >

Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-08 Thread Jerin Jacob
On Sun, Nov 8, 2020 at 2:03 AM Thomas Monjalon wrote: > > 07/11/2020 20:05, Jerin Jacob: > > On Sun, Nov 8, 2020 at 12:09 AM Thomas Monjalon wrote: > > > 07/11/2020 18:12, Jerin Jacob: > > > > On Sat, Nov 7, 2020 at 10:04 PM Thomas Monjalon > > > > wrote: > > > > > > > > > > The mempool pointer

Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-07 Thread Thomas Monjalon
07/11/2020 20:05, Jerin Jacob: > On Sun, Nov 8, 2020 at 12:09 AM Thomas Monjalon wrote: > > 07/11/2020 18:12, Jerin Jacob: > > > On Sat, Nov 7, 2020 at 10:04 PM Thomas Monjalon > > > wrote: > > > > > > > > The mempool pointer in the mbuf struct is moved > > > > from the second to the first half.

Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-07 Thread Jerin Jacob
On Sun, Nov 8, 2020 at 12:09 AM Thomas Monjalon wrote: > > 07/11/2020 18:12, Jerin Jacob: > > On Sat, Nov 7, 2020 at 10:04 PM Thomas Monjalon wrote: > > > > > > The mempool pointer in the mbuf struct is moved > > > from the second to the first half. > > > It should increase performance on most sy

Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-07 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Saturday, November 7, 2020 4:53 PM > > The mempool pointer in the mbuf struct is moved > from the second to the first half. > It should increase performance on most systems having 64-byte cache line, > i.e. mbuf is split in two cache lin

Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-07 Thread Thomas Monjalon
07/11/2020 18:12, Jerin Jacob: > On Sat, Nov 7, 2020 at 10:04 PM Thomas Monjalon wrote: > > > > The mempool pointer in the mbuf struct is moved > > from the second to the first half. > > It should increase performance on most systems having 64-byte cache line, > > > i.e. mbuf is split in two cach

Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-07 Thread Jerin Jacob
On Sat, Nov 7, 2020 at 10:04 PM Thomas Monjalon wrote: > > The mempool pointer in the mbuf struct is moved > from the second to the first half. > It should increase performance on most systems having 64-byte cache line, > i.e. mbuf is split in two cache lines. But In any event, Tx needs to touch

[dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half

2020-11-07 Thread Thomas Monjalon
The mempool pointer in the mbuf struct is moved from the second to the first half. It should increase performance on most systems having 64-byte cache line, i.e. mbuf is split in two cache lines. Due to this change, tx_offload is moved, so some vector data paths may need to be adjusted. Note: OCTE