Re: [dpdk-dev] [PATCH 06/12] eal: add channel for primary/secondary communication

2017-09-29 Thread Yuanhan Liu
On Fri, Sep 29, 2017 at 11:09:23AM +0100, Burakov, Anatoly wrote: > On 29-Sep-17 2:24 AM, Yuanhan Liu wrote: > >On Thu, Sep 28, 2017 at 01:50:20PM +, Tan, Jianfeng wrote: > +/** Path of primary/secondary communication unix socket file. */ > +#define PRIMARY_SECONDARY_UNIX_PATH_FMT "%s/.

Re: [dpdk-dev] [PATCH 06/12] eal: add channel for primary/secondary communication

2017-09-29 Thread Burakov, Anatoly
On 29-Sep-17 2:24 AM, Yuanhan Liu wrote: On Thu, Sep 28, 2017 at 01:50:20PM +, Tan, Jianfeng wrote: +/** Path of primary/secondary communication unix socket file. */ +#define PRIMARY_SECONDARY_UNIX_PATH_FMT "%s/.%s_unix" +static inline const char * +eal_primary_secondary_unix_path(void) +{ +

Re: [dpdk-dev] [PATCH 06/12] eal: add channel for primary/secondary communication

2017-09-28 Thread Yuanhan Liu
On Thu, Sep 28, 2017 at 01:50:20PM +, Tan, Jianfeng wrote: > > > +int > > > +rte_eal_primary_secondary_add_action(const char *action_name, > > > + rte_eal_primary_secondary_t action) > > > +{ > > > + struct action_entry *entry = malloc(sizeof(struct action_entry));

Re: [dpdk-dev] [PATCH 06/12] eal: add channel for primary/secondary communication

2017-09-28 Thread Tan, Jianfeng
Yuanhan, Thank you for the detailed review! Most of your suggestions are very good and I'll fix them in next version. > -Original Message- > From: Yuanhan Liu [mailto:y...@fridaylinux.org] > Sent: Wednesday, September 27, 2017 8:20 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; Richardson, B

Re: [dpdk-dev] [PATCH 06/12] eal: add channel for primary/secondary communication

2017-09-27 Thread Yuanhan Liu
On Fri, Aug 25, 2017 at 09:40:46AM +, Jianfeng Tan wrote: > Previouly, there is only one way for primary/secondary to exchange > messages, that is, primary process writes info into some predefind > file, and secondary process reads info out. That cannot address > the requirements: > a. Second

Re: [dpdk-dev] [PATCH 06/12] eal: add channel for primary/secondary communication

2017-09-20 Thread Tan, Jianfeng
Hi Jiayu, On 9/20/2017 11:00 AM, Jiayu Hu wrote: Hi Jianfeng, Few questions are inline. Thanks, Jiayu On Fri, Aug 25, 2017 at 09:40:46AM +, Jianfeng Tan wrote: Previouly, there is only one way for primary/secondary to exchange messages, that is, primary process writes info into some pre

Re: [dpdk-dev] [PATCH 06/12] eal: add channel for primary/secondary communication

2017-09-20 Thread Tan, Jianfeng
Hi Jiayu, On 9/18/2017 9:49 PM, Jiayu Hu wrote: Hi Jianfeng, On Fri, Aug 25, 2017 at 09:40:46AM +, Jianfeng Tan wrote: Previouly, there is only one way for primary/secondary to exchange messages, that is, primary process writes info into some predefind file, and secondary process reads i

Re: [dpdk-dev] [PATCH 06/12] eal: add channel for primary/secondary communication

2017-09-19 Thread Jiayu Hu
Hi Jianfeng, Few questions are inline. Thanks, Jiayu On Fri, Aug 25, 2017 at 09:40:46AM +, Jianfeng Tan wrote: > Previouly, there is only one way for primary/secondary to exchange > messages, that is, primary process writes info into some predefind > file, and secondary process reads info ou

Re: [dpdk-dev] [PATCH 06/12] eal: add channel for primary/secondary communication

2017-09-18 Thread Jiayu Hu
Hi Jianfeng, On Fri, Aug 25, 2017 at 09:40:46AM +, Jianfeng Tan wrote: > Previouly, there is only one way for primary/secondary to exchange > messages, that is, primary process writes info into some predefind > file, and secondary process reads info out. That cannot address > the requirements

[dpdk-dev] [PATCH 06/12] eal: add channel for primary/secondary communication

2017-08-25 Thread Jianfeng Tan
Previouly, there is only one way for primary/secondary to exchange messages, that is, primary process writes info into some predefind file, and secondary process reads info out. That cannot address the requirements: a. Secondary wants to send info to primary. b. Sending info at any time, instea