Re: [dpdk-dev] [PATCH 01/29] net/ena: check if size of buffer is at least 1400B

2020-03-31 Thread Michał Krawczyk
pt., 27 mar 2020 o 15:51 Stephen Hemminger napisał(a): > > On Fri, 27 Mar 2020 11:17:55 +0100 > Michal Krawczyk wrote: > > > + /* ENA isn't supporting buffers smaller than 1400 bytes */ > > + buffer_size = mp->elt_size - sizeof(struct rte_mbuf) - > > + RTE_PKTMBUF_HEADROOM; >

Re: [dpdk-dev] [PATCH 01/29] net/ena: check if size of buffer is at least 1400B

2020-03-31 Thread Michał Krawczyk
pt., 27 mar 2020 o 11:56 Andrew Rybchenko napisał(a): > > On 3/27/20 1:17 PM, Michal Krawczyk wrote: > > Some of the ENA devices can't handle buffers which are smaller than a > > 1400B. Because of this limitation, size of the buffer is being checked > > and limited during the Rx queue setup. > > >

Re: [dpdk-dev] [PATCH 01/29] net/ena: check if size of buffer is at least 1400B

2020-03-27 Thread Stephen Hemminger
On Fri, 27 Mar 2020 11:17:55 +0100 Michal Krawczyk wrote: > + /* ENA isn't supporting buffers smaller than 1400 bytes */ > + buffer_size = mp->elt_size - sizeof(struct rte_mbuf) - > + RTE_PKTMBUF_HEADROOM; This should use rte_pktmbuf_data_room_size(mp) - RTE_PKTMBUF_HEADROOM

Re: [dpdk-dev] [PATCH 01/29] net/ena: check if size of buffer is at least 1400B

2020-03-27 Thread Andrew Rybchenko
On 3/27/20 1:17 PM, Michal Krawczyk wrote: > Some of the ENA devices can't handle buffers which are smaller than a > 1400B. Because of this limitation, size of the buffer is being checked > and limited during the Rx queue setup. > > If it's below the allowed value, PMD won't finish it's configurat

[dpdk-dev] [PATCH 01/29] net/ena: check if size of buffer is at least 1400B

2020-03-27 Thread Michal Krawczyk
Some of the ENA devices can't handle buffers which are smaller than a 1400B. Because of this limitation, size of the buffer is being checked and limited during the Rx queue setup. If it's below the allowed value, PMD won't finish it's configuration successfully.. Signed-off-by: Michal Krawczyk R