Re: [dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-30 Thread Jerin Jacob
On Tue, Jun 30, 2020 at 7:09 PM David Marchand wrote: > > On Fri, Jun 26, 2020 at 2:38 PM Jerin Jacob wrote: > > > Or no declaration in macro and leave code as it is. > > > > I dont see anything wrong with that. Do you have technical rationale > > for the above rule? > > Avoid global symbols when

Re: [dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-30 Thread David Marchand
On Fri, Jun 26, 2020 at 2:38 PM Jerin Jacob wrote: > > Or no declaration in macro and leave code as it is. > > I dont see anything wrong with that. Do you have technical rationale > for the above rule? Avoid global symbols when unneeded. Global symbols can be hidden with shared build, but that's

Re: [dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-29 Thread Jerin Jacob
On Fri, Jun 26, 2020 at 6:07 PM Jerin Jacob wrote: > > On Fri, Jun 26, 2020 at 5:46 PM David Marchand > wrote: > > > > On Fri, Jun 26, 2020 at 2:06 PM Jerin Jacob wrote: > > > > > > On Fri, Jun 26, 2020 at 5:13 PM David Marchand > > > wrote: > > > > > > > > On Fri, Jun 26, 2020 at 1:16 PM Jerin

Re: [dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-26 Thread Jerin Jacob
On Fri, Jun 26, 2020 at 5:46 PM David Marchand wrote: > > On Fri, Jun 26, 2020 at 2:06 PM Jerin Jacob wrote: > > > > On Fri, Jun 26, 2020 at 5:13 PM David Marchand > > wrote: > > > > > > On Fri, Jun 26, 2020 at 1:16 PM Jerin Jacob wrote: > > > > > > Alternative is to keep variable declaration o

Re: [dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-26 Thread David Marchand
On Fri, Jun 26, 2020 at 2:06 PM Jerin Jacob wrote: > > On Fri, Jun 26, 2020 at 5:13 PM David Marchand > wrote: > > > > On Fri, Jun 26, 2020 at 1:16 PM Jerin Jacob wrote: > > > > > Alternative is to keep variable declaration outside, > > > > > as David suggested, and I tend to agree that it is a

Re: [dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-26 Thread David Marchand
On Fri, Jun 26, 2020 at 2:06 PM Jerin Jacob wrote: > > On Fri, Jun 26, 2020 at 5:13 PM David Marchand > wrote: > > > > On Fri, Jun 26, 2020 at 1:16 PM Jerin Jacob wrote: > > > > > Alternative is to keep variable declaration outside, > > > > > as David suggested, and I tend to agree that it is a

Re: [dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-26 Thread Jerin Jacob
On Fri, Jun 26, 2020 at 5:13 PM David Marchand wrote: > > On Fri, Jun 26, 2020 at 1:16 PM Jerin Jacob wrote: > > > > Alternative is to keep variable declaration outside, > > > > as David suggested, and I tend to agree that it is a > > > > bit better. Macro name says 'register'. It is not > > > >

Re: [dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-26 Thread David Marchand
On Fri, Jun 26, 2020 at 1:16 PM Jerin Jacob wrote: > > > Alternative is to keep variable declaration outside, > > > as David suggested, and I tend to agree that it is a > > > bit better. Macro name says 'register'. It is not > > > 'declare and register'. Also it avoids static-vs-extern > > > probl

Re: [dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-26 Thread Jerin Jacob
On Wed, Jun 24, 2020 at 11:40 PM Jerin Jacob wrote: > > On Wed, Jun 24, 2020 at 9:13 PM Andrew Rybchenko > wrote: > > > > On 6/24/20 6:32 PM, Jerin Jacob wrote: > > > On Wed, Jun 24, 2020 at 8:56 PM Andrew Rybchenko > > > wrote: > > >> > > >> On 6/24/20 4:11 PM, Jerin Jacob wrote: > > >>> On Wed

Re: [dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-24 Thread Jerin Jacob
On Wed, Jun 24, 2020 at 9:13 PM Andrew Rybchenko wrote: > > On 6/24/20 6:32 PM, Jerin Jacob wrote: > > On Wed, Jun 24, 2020 at 8:56 PM Andrew Rybchenko > > wrote: > >> > >> On 6/24/20 4:11 PM, Jerin Jacob wrote: > >>> On Wed, Jun 17, 2020 at 3:51 PM Andrew Rybchenko > >>> wrote: > > On

Re: [dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-24 Thread Andrew Rybchenko
On 6/24/20 6:32 PM, Jerin Jacob wrote: > On Wed, Jun 24, 2020 at 8:56 PM Andrew Rybchenko > wrote: >> >> On 6/24/20 4:11 PM, Jerin Jacob wrote: >>> On Wed, Jun 17, 2020 at 3:51 PM Andrew Rybchenko >>> wrote: On 6/17/20 1:02 PM, David Marchand wrote: > On Wed, Jun 17, 2020 at 8:30 AM

Re: [dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-24 Thread Jerin Jacob
On Wed, Jun 24, 2020 at 8:56 PM Andrew Rybchenko wrote: > > On 6/24/20 4:11 PM, Jerin Jacob wrote: > > On Wed, Jun 17, 2020 at 3:51 PM Andrew Rybchenko > > wrote: > >> > >> On 6/17/20 1:02 PM, David Marchand wrote: > >>> On Wed, Jun 17, 2020 at 8:30 AM wrote: > > From: Jerin Jacob > >

Re: [dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-24 Thread Andrew Rybchenko
On 6/24/20 4:11 PM, Jerin Jacob wrote: > On Wed, Jun 17, 2020 at 3:51 PM Andrew Rybchenko > wrote: >> >> On 6/17/20 1:02 PM, David Marchand wrote: >>> On Wed, Jun 17, 2020 at 8:30 AM wrote: From: Jerin Jacob Introducing the RTE_LOG_REGISTER macro to avoid the code duplication

Re: [dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-24 Thread Jerin Jacob
On Wed, Jun 17, 2020 at 3:51 PM Andrew Rybchenko wrote: > > On 6/17/20 1:02 PM, David Marchand wrote: > > On Wed, Jun 17, 2020 at 8:30 AM wrote: > >> > >> From: Jerin Jacob > >> > >> Introducing the RTE_LOG_REGISTER macro to avoid the code duplication > >> in the log registration process. > >> >

Re: [dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-24 Thread Jerin Jacob
On Wed, Jun 17, 2020 at 3:56 PM Andrew Rybchenko wrote: > > On 6/17/20 1:00 PM, Thomas Monjalon wrote: > > 17/06/2020 08:30, jer...@marvell.com: > >> From: Jerin Jacob > >> > >> Introducing the RTE_LOG_REGISTER macro to avoid the code duplication > >> in the log registration process. > >> > >> It

Re: [dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-21 Thread Sachin Saxena (OSS)
On 17-Jun-20 12:00 PM, jer...@marvell.com wrote: From: Jerin Jacob Introducing the RTE_LOG_REGISTER macro to avoid the code duplication in the log registration process. It is a wrapper macro for declaring the logtype, register the log and sets it's level in the constructor context. Signed-off

Re: [dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-17 Thread Andrew Rybchenko
On 6/17/20 1:00 PM, Thomas Monjalon wrote: > 17/06/2020 08:30, jer...@marvell.com: >> From: Jerin Jacob >> >> Introducing the RTE_LOG_REGISTER macro to avoid the code duplication >> in the log registration process. >> >> It is a wrapper macro for declaring the logtype, register the log and sets >>

Re: [dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-17 Thread Andrew Rybchenko
On 6/17/20 1:02 PM, David Marchand wrote: > On Wed, Jun 17, 2020 at 8:30 AM wrote: >> >> From: Jerin Jacob >> >> Introducing the RTE_LOG_REGISTER macro to avoid the code duplication >> in the log registration process. >> >> It is a wrapper macro for declaring the logtype, register the log and set

Re: [dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-17 Thread David Marchand
On Wed, Jun 17, 2020 at 8:30 AM wrote: > > From: Jerin Jacob > > Introducing the RTE_LOG_REGISTER macro to avoid the code duplication > in the log registration process. > > It is a wrapper macro for declaring the logtype, register the log and sets Having the logtype variable declared as part of

Re: [dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-17 Thread Thomas Monjalon
17/06/2020 08:30, jer...@marvell.com: > From: Jerin Jacob > > Introducing the RTE_LOG_REGISTER macro to avoid the code duplication > in the log registration process. > > It is a wrapper macro for declaring the logtype, register the log and sets > it's level in the constructor context. > > Signe

[dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-16 Thread jerinj
From: Jerin Jacob Introducing the RTE_LOG_REGISTER macro to avoid the code duplication in the log registration process. It is a wrapper macro for declaring the logtype, register the log and sets it's level in the constructor context. Signed-off-by: Jerin Jacob --- lib/librte_eal/include/rte_l