[dpdk-dev] [PATCH 01/11] ixgbe: clean log messages

2014-08-29 Thread David Marchand
On Wed, Aug 27, 2014 at 8:06 PM, Stephen Hemminger < stephen at networkplumber.org> wrote: > On Wed, 27 Aug 2014 08:53:46 -0500 > Jay Rolette wrote: > > > The updated output is definitely an improvement, but if you'll go with > the > > first solution you described (adding \n in the log macro), it

[dpdk-dev] [PATCH 01/11] ixgbe: clean log messages

2014-08-27 Thread Stephen Hemminger
On Wed, 27 Aug 2014 08:53:46 -0500 Jay Rolette wrote: > The updated output is definitely an improvement, but if you'll go with the > first solution you described (adding \n in the log macro), it works much > better for products using DPDK. For developer use, I think it ends up being > a wash eith

[dpdk-dev] [PATCH 01/11] ixgbe: clean log messages

2014-08-27 Thread Jay Rolette
Hi David, The updated output is definitely an improvement, but if you'll go with the first solution you described (adding \n in the log macro), it works much better for products using DPDK. For developer use, I think it ends up being a wash either way. At least for my product (embedded network ap

[dpdk-dev] [PATCH 01/11] ixgbe: clean log messages

2014-08-26 Thread David Marchand
Hello Jay, On Tue, Aug 26, 2014 at 4:23 PM, Jay Rolette wrote: > Why are you adding newlines to log message strings? Shouldn't that be up > to whatever the messages end up getting routed to? > Actually, I wanted to have consistent log formats in the PMDs so that the log messages displayed at ru

[dpdk-dev] [PATCH 01/11] ixgbe: clean log messages

2014-08-26 Thread David Marchand
Clean log messages: - remove superfluous \n in log macros and add some \n where needed, - remove leading \n in some messages, - split multi lines messages, - replace some PMD_INIT_LOG(DEBUG, "some_func\n") with PMD_INIT_FUNC_TRACE(). Signed-off-by: David Marchand --- lib/librte_pmd_ixgbe/ixgbe_e

[dpdk-dev] [PATCH 01/11] ixgbe: clean log messages

2014-08-26 Thread Jay Rolette
Why are you adding newlines to log message strings? Shouldn't that be up to whatever the messages end up getting routed to? Jay On Tue, Aug 26, 2014 at 9:09 AM, David Marchand wrote: > Clean log messages: > - remove superfluous \n in log macros and add some \n where needed, > - remove leading