Re: [dpdk-dev] [PATCH 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-10-29 Thread Vijay Kumar Srivastava
Hi Stephen, >-Original Message- >From: Stephen Hemminger >Sent: Friday, August 13, 2021 9:06 PM >To: Vijay Kumar Srivastava >Cc: dev@dpdk.org; maxime.coque...@redhat.com; chenbo@intel.com; >andrew.rybche...@oktetlabs.ru; Vijay Kumar Srivastava >Subject: Re: [d

Re: [dpdk-dev] [PATCH 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-10-28 Thread Vijay Kumar Srivastava
Hi Stephen, >-Original Message- >From: Stephen Hemminger >Sent: Friday, August 13, 2021 9:07 PM >To: Vijay Kumar Srivastava >Cc: dev@dpdk.org; maxime.coque...@redhat.com; chenbo@intel.com; >andrew.rybche...@oktetlabs.ru; Vijay Kumar Srivastava >Subject: Re: [d

Re: [dpdk-dev] [PATCH 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-08-15 Thread Xia, Chenbo
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Friday, August 13, 2021 5:31 PM > To: Xia, Chenbo ; Vijay Srivastava > ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Vijay Kumar Srivastava > Subject: Re: [PATCH 01/10] vdpa/sfc: introduce Xilinx vDPA driver > > On 8/13

Re: [dpdk-dev] [PATCH 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-08-13 Thread Stephen Hemminger
On Tue, 6 Jul 2021 22:14:09 +0530 Vijay Srivastava wrote: > +static pthread_mutex_t sfc_vdpa_adapter_list_lock = > PTHREAD_MUTEX_INITIALIZER; > + Why do you need a pthread_mutex when simple DPDK spin lock will do?

Re: [dpdk-dev] [PATCH 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-08-13 Thread Stephen Hemminger
On Tue, 6 Jul 2021 22:14:09 +0530 Vijay Srivastava wrote: > +uint32_t > +sfc_vdpa_register_logtype(const struct rte_pci_addr *pci_addr, > + const char *lt_prefix_str, uint32_t ll_default) > +{ > + size_t lt_prefix_str_size = strlen(lt_prefix_str); > + size_t lt_str_s

Re: [dpdk-dev] [PATCH 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-08-13 Thread Stephen Hemminger
On Tue, 6 Jul 2021 22:14:09 +0530 Vijay Srivastava wrote: > +# Enable more warnings > +extra_flags += [ > + '-Wdisabled-optimization' > +] > + > +# Compiler and version dependent flags > +extra_flags += [ > + '-Waggregate-return', > + '-Wbad-function-cast' > +] > + Having each driver

Re: [dpdk-dev] [PATCH 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-08-13 Thread Andrew Rybchenko
On 8/13/21 12:23 PM, Xia, Chenbo wrote: > Hi Andrew, > >> -Original Message- >> From: Andrew Rybchenko >> Sent: Friday, August 13, 2021 4:39 PM >> To: Xia, Chenbo ; Vijay Srivastava >> ; dev@dpdk.org >> Cc: maxime.coque...@redhat.com; Vijay Kumar Srivastava >> Subject: Re: [PATCH 01/10]

Re: [dpdk-dev] [PATCH 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-08-13 Thread Xia, Chenbo
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Friday, August 13, 2021 4:39 PM > To: Xia, Chenbo ; Vijay Srivastava > ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Vijay Kumar Srivastava > Subject: Re: [PATCH 01/10] vdpa/sfc: introduce Xilinx vDPA driver > > Hi Chen

Re: [dpdk-dev] [PATCH 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-08-13 Thread Andrew Rybchenko
Hi Chenbo, many thanks for review. See few questions/notes below. On 8/11/21 5:26 AM, Xia, Chenbo wrote: > Hi Vijay, > >> -Original Message- >> From: Vijay Srivastava >> Sent: Wednesday, July 7, 2021 12:44 AM >> To: dev@dpdk.org >> Cc: maxime.coque...@redhat.com; Xia, Chenbo ; >> andrew

Re: [dpdk-dev] [PATCH 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-08-10 Thread Xia, Chenbo
Hi Vijay, > -Original Message- > From: Vijay Srivastava > Sent: Wednesday, July 7, 2021 12:44 AM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; > andrew.rybche...@oktetlabs.ru; Vijay Kumar Srivastava > Subject: [PATCH 01/10] vdpa/sfc: introduce Xilinx vDPA driver > >

[dpdk-dev] [PATCH 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-07-07 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Add new vDPA PMD to support vDPA operation by Xilinx devices. This patch implements probe and remove functions. Signed-off-by: Vijay Kumar Srivastava --- MAINTAINERS| 6 + doc/guides/rel_notes/release_21_08.rst | 5 + doc/guides/vdpa