Re: [dpdk-dev] [PATCH 0/8] QoS features on i40e

2017-03-27 Thread Ferruh Yigit
On 2/24/2017 3:24 AM, Wenzhuo Lu wrote: > This patch set enables several QoS features on i40e. > 1, VF max bandwidth setting. > 2, TC min bandwidth setting on a VF. > 3, TC max bandwidth setting on a VF. > 4, TC TX scheduling mode setting. > As there're no new interface between PF and VF defined, a

Re: [dpdk-dev] [PATCH 0/8] QoS features on i40e - Linux kernel divergence

2017-02-27 Thread Lu, Wenzhuo
Hi Vincent, > -Original Message- > From: Vincent JARDIN [mailto:vincent.jar...@6wind.com] > Sent: Friday, February 24, 2017 5:14 PM > To: Lu, Wenzhuo; Stephen Hemminger > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/8] QoS features on i40e - Linux kernel > div

Re: [dpdk-dev] [PATCH 0/8] QoS features on i40e - Linux kernel divergence

2017-02-24 Thread Vincent JARDIN
Le 24/02/2017 à 08:23, Lu, Wenzhuo a écrit : It is good to allow setting QoS on device, but it looks like this is a device specific API, not a generic PMD function. I don't think any feature in DPDK should be hardcoded to one device type. Yes, they're private APIs. Normally we want to support ke

Re: [dpdk-dev] [PATCH 0/8] QoS features on i40e

2017-02-23 Thread Lu, Wenzhuo
Hi Stephen, > -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, February 24, 2017 2:55 PM > To: Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/8] QoS features on i40e > > On Fri, 24 Feb 2017 11:

Re: [dpdk-dev] [PATCH 0/8] QoS features on i40e

2017-02-23 Thread Stephen Hemminger
On Fri, 24 Feb 2017 11:24:27 +0800 Wenzhuo Lu wrote: > This patch set enables several QoS features on i40e. > 1, VF max bandwidth setting. > 2, TC min bandwidth setting on a VF. > 3, TC max bandwidth setting on a VF. > 4, TC TX scheduling mode setting. > As there're no new interface between PF an

[dpdk-dev] [PATCH 0/8] QoS features on i40e

2017-02-23 Thread Wenzhuo Lu
This patch set enables several QoS features on i40e. 1, VF max bandwidth setting. 2, TC min bandwidth setting on a VF. 3, TC max bandwidth setting on a VF. 4, TC TX scheduling mode setting. As there're no new interface between PF and VF defined, all the settings for VF are done on PF. PF acts as a