Re: [dpdk-dev] [PATCH 0/2] remove use of weak functions from libraries

2019-06-05 Thread Thomas Monjalon
10/04/2019 15:45, Bruce Richardson: > Weak functions don't work well with static library builds as the linker > always picks the first version of a function irrespective of whether it is > weak or not. The solution to this is to use the "whole-archive" flag when > linking, but this has the nasty si

Re: [dpdk-dev] [PATCH 0/2] remove use of weak functions from libraries

2019-05-28 Thread Bruce Richardson
On Mon, May 27, 2019 at 04:57:15PM -0400, Aaron Conole wrote: > Bruce Richardson writes: > > > On Mon, May 27, 2019 at 04:13:53PM +0200, David Marchand wrote: > >>Hello, > >>On Wed, Apr 10, 2019 at 3:45 PM Bruce Richardson > >><[1]bruce.richard...@intel.com> wrote: > >> > >> Wea

Re: [dpdk-dev] [PATCH 0/2] remove use of weak functions from libraries

2019-05-27 Thread Aaron Conole
Bruce Richardson writes: > On Mon, May 27, 2019 at 04:13:53PM +0200, David Marchand wrote: >>Hello, >>On Wed, Apr 10, 2019 at 3:45 PM Bruce Richardson >><[1]bruce.richard...@intel.com> wrote: >> >> Weak functions don't work well with static library builds as the >> linker >

Re: [dpdk-dev] [PATCH 0/2] remove use of weak functions from libraries

2019-05-27 Thread Bruce Richardson
On Mon, May 27, 2019 at 04:13:53PM +0200, David Marchand wrote: >Hello, >On Wed, Apr 10, 2019 at 3:45 PM Bruce Richardson ><[1]bruce.richard...@intel.com> wrote: > > Weak functions don't work well with static library builds as the > linker > always picks the first versio

Re: [dpdk-dev] [PATCH 0/2] remove use of weak functions from libraries

2019-05-27 Thread David Marchand
Hello, On Wed, Apr 10, 2019 at 3:45 PM Bruce Richardson wrote: > Weak functions don't work well with static library builds as the linker > always picks the first version of a function irrespective of whether it is > weak or not. The solution to this is to use the "whole-archive" flag when > link

[dpdk-dev] [PATCH 0/2] remove use of weak functions from libraries

2019-04-10 Thread Bruce Richardson
Weak functions don't work well with static library builds as the linker always picks the first version of a function irrespective of whether it is weak or not. The solution to this is to use the "whole-archive" flag when linking, but this has the nasty side-effect that it causes the resulting binar