Hi Fan,
On 2018/1/30 1:19, Zhang, Roy Fan wrote:
Hi Jay,
A few more comments inline.
-Original Message-
From: Jay Zhou [mailto:jianjay.z...@huawei.com]
Sent: Friday, November 17, 2017 5:10 PM
To: dev@dpdk.org
Cc: y...@fridaylinux.org; maxime.coque...@redhat.com;
arei.gong...@huawei.co
Hi Jay,
> > + switch (cmd_id) {
> > + case VIRTIO_CRYPTO_CMD_CIPHER_HASH:
> > + case VIRTIO_CRYPTO_CMD_HASH_CIPHER:
> > + ctrl->u.sym_create_session.op_type
> > + = VIRTIO_CRYPTO_SYM_OP_ALGORITHM_CHAINING;
>
> The above line is clearly a bug.
My bad, it isn't a
Hi Jay,
A few more comments inline.
> -Original Message-
> From: Jay Zhou [mailto:jianjay.z...@huawei.com]
> Sent: Friday, November 17, 2017 5:10 PM
> To: dev@dpdk.org
> Cc: y...@fridaylinux.org; maxime.coque...@redhat.com;
> arei.gong...@huawei.com; Zhang, Roy Fan ; Zeng,
> Xin ; weidon
22/01/2018 18:25, Zhang, Roy Fan:
> Hi Thomas,
>
> Yes we are working together on this. Jay and Lei kindly agreed to upstream
> their work.
>
> Jay is also working on Qemu patches to enable vhost-user as crypto backend
> (https://patchwork.ozlabs.org/patch/864058/).
> Jay's Qemu patches' mergi
; Cc: dev@dpdk.org; Zhang, Roy Fan ;
> y...@fridaylinux.org; maxime.coque...@redhat.com;
> arei.gong...@huawei.com; Zeng, Xin ;
> weidong.hu...@huawei.com; wangxinxin.w...@huawei.com;
> longpe...@huawei.com; Yigit, Ferruh ; De Lara
> Guarch, Pablo
> Subject: Re: [dpdk-dev] [PATCH] vi
Xin ; Huangweidong (C)
> ; wangxin (U) ;
> longpeng ; ferruh.yi...@intel.com
> Subject: Re: [dpdk-dev] [PATCH] virtio: add new driver for crypto devices
>
> Hi,
>
> 28/11/2017 02:27, Jay Zhou:
> > For DPDK, I'm a newbie. Thanks for testing and pointing these steps
&
+Cc Pablo, maintainer of the crypto tree
20/01/2018 16:50, Thomas Monjalon:
> Hi,
>
> 28/11/2017 02:27, Jay Zhou:
> > For DPDK, I'm a newbie. Thanks for testing and pointing these steps
> > out, will fix them in V2.
>
> Any news about this work?
>
> I see there is also a patch from Fan Zhang to
Hi,
28/11/2017 02:27, Jay Zhou:
> For DPDK, I'm a newbie. Thanks for testing and pointing these steps
> out, will fix them in V2.
Any news about this work?
I see there is also a patch from Fan Zhang to support crypto in vhost-user.
Do you work together?
Hi Jay,
No worries. Welcome to DPDK :-D
Regards,
Fan
> -Original Message-
> From: Jay Zhou [mailto:jianjay.z...@huawei.com]
> Sent: Tuesday, November 28, 2017 1:27 AM
> To: Zhang, Roy Fan ; dev@dpdk.org
> Cc: y...@fridaylinux.org; maxime.coque...@redhat.com;
> arei.gong...@huawei.com; Ze
Hi Fan,
On 2017/11/28 0:47, Zhang, Roy Fan wrote:
Hi Jay,
Thanks for contributing to DPDK.
The code has been tested and works fine.
A few comments:
1. Could you split the patch into a patchset, as suggested in contribution
guide in http://dpdk.org/doc/guides/contributing/patches.html, secti
Hi Jay,
Thanks for contributing to DPDK.
The code has been tested and works fine.
A few comments:
1. Could you split the patch into a patchset, as suggested in contribution
guide in http://dpdk.org/doc/guides/contributing/patches.html, section 5.4?
2. Please update doc/guides/cryptodevs for d
11 matches
Mail list logo
