Re: [dpdk-dev] [PATCH] vhost: return ready when at least 1 vring is configured

2020-10-01 Thread Zhang, Roy Fan
@dpdk.org > Cc: ma...@mellanox.com; Zawadzki, Tomasz ; > Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH] vhost: return ready when at least 1 vring is > configured > > Hi Fan, > > On 10/1/20 10:07 AM, Zhang, Roy Fan wrote: > > Hi Maxime, > > > >> -Origin

Re: [dpdk-dev] [PATCH] vhost: return ready when at least 1 vring is configured

2020-10-01 Thread Maxime Coquelin
ma...@mellanox.com; Zawadzki, Tomasz ; >> Yigit, Ferruh >> Subject: Re: [dpdk-dev] [PATCH] vhost: return ready when at least 1 vring is >> configured >> >> >> >> On 9/30/20 6:37 PM, Zhang, Roy Fan wrote: >>> Hi Chenbo and Maxime, >>> >

Re: [dpdk-dev] [PATCH] vhost: return ready when at least 1 vring is configured

2020-10-01 Thread Zhang, Roy Fan
me Coquelin > >> Sent: Wednesday, September 30, 2020 4:37 PM > >> To: Xia, Chenbo ; Zhang, Roy Fan > >> ; Liu, Changpeng ; > >> dev@dpdk.org > >> Cc: ma...@mellanox.com; Zawadzki, Tomasz > ; > >> Yigit, Ferruh > >> Subject: Re: [

Re: [dpdk-dev] [PATCH] vhost: return ready when at least 1 vring is configured

2020-10-01 Thread Maxime Coquelin
; Liu, Changpeng ; >> dev@dpdk.org >> Cc: ma...@mellanox.com; Zawadzki, Tomasz ; >> Yigit, Ferruh >> Subject: Re: [dpdk-dev] [PATCH] vhost: return ready when at least 1 vring is >> configured >> >> Hi, >> >> On 9/30/20 4:48 AM, Xia, C

Re: [dpdk-dev] [PATCH] vhost: return ready when at least 1 vring is configured

2020-09-30 Thread Zhang, Roy Fan
asz ; > Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH] vhost: return ready when at least 1 vring is > configured > > Hi, > > On 9/30/20 4:48 AM, Xia, Chenbo wrote: > > Hi Fan & Maxime, > > > > I am thinking that should we move set_features outside of new_device

Re: [dpdk-dev] [PATCH] vhost: return ready when at least 1 vring is configured

2020-09-30 Thread Maxime Coquelin
in ; Liu, Changpeng >> ; dev@dpdk.org >> Cc: ma...@mellanox.com; Xia, Chenbo ; Zawadzki, >> Tomasz ; Yigit, Ferruh >> Subject: RE: [dpdk-dev] [PATCH] vhost: return ready when at least 1 vring >> is configured >> >> Hi Maxime, >> >> Thanks for telling m

Re: [dpdk-dev] [PATCH] vhost: return ready when at least 1 vring is configured

2020-09-29 Thread Xia, Chenbo
gs themselves either. > > Regards, > Fan > > > > -----Original Message----- > > From: Maxime Coquelin > > Sent: Tuesday, September 29, 2020 3:06 PM > > To: Zhang, Roy Fan ; Liu, Changpeng > > ; dev@dpdk.org > > Cc: ma...@mellanox.com; Xia, Chenbo ;

Re: [dpdk-dev] [PATCH] vhost: return ready when at least 1 vring is configured

2020-09-29 Thread Zhang, Roy Fan
e the user to set the flags themselves either. Regards, Fan > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, September 29, 2020 3:06 PM > To: Zhang, Roy Fan ; Liu, Changpeng > ; dev@dpdk.org > Cc: ma...@mellanox.com; Xia, Chenbo ; Zawadzki, > Tomasz > Subject: Re:

Re: [dpdk-dev] [PATCH] vhost: return ready when at least 1 vring is configured

2020-09-29 Thread Maxime Coquelin
-Original Message- >> From: dev On Behalf Of Maxime Coquelin >> Sent: Wednesday, September 23, 2020 9:05 AM >> To: Liu, Changpeng ; dev@dpdk.org >> Cc: ma...@mellanox.com; Xia, Chenbo ; Zawadzki, >> Tomasz >> Subject: Re: [dpdk-dev] [PATCH] vhost: retur

Re: [dpdk-dev] [PATCH] vhost: return ready when at least 1 vring is configured

2020-09-29 Thread Zhang, Roy Fan
5 AM > To: Liu, Changpeng ; dev@dpdk.org > Cc: ma...@mellanox.com; Xia, Chenbo ; Zawadzki, > Tomasz > Subject: Re: [dpdk-dev] [PATCH] vhost: return ready when at least 1 vring is > configured > > Hi Changpeng, > > On 9/22/20 9:22 AM, Liu, Changpeng wrote: > > Hi M

Re: [dpdk-dev] [PATCH] vhost: return ready when at least 1 vring is configured

2020-09-23 Thread Liu, Changpeng
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, September 23, 2020 4:05 PM > To: Liu, Changpeng ; dev@dpdk.org > Cc: ma...@mellanox.com; Xia, Chenbo ; Zawadzki, > Tomasz > Subject: Re: [PATCH] vhost: return ready when at least 1 vring is configured > > Hi Changpeng, >

Re: [dpdk-dev] [PATCH] vhost: return ready when at least 1 vring is configured

2020-09-23 Thread Maxime Coquelin
Hi Changpeng, On 9/22/20 9:22 AM, Liu, Changpeng wrote: > Hi Maxime, > > The code you wrote still need to check nr_vring is 0 or not, see the extra 2 > lines added below, then it can work with my tests for now, could you submit a > patch to DPDK to apply the patch? Thanks. Thanks! You are righ

Re: [dpdk-dev] [PATCH] vhost: return ready when at least 1 vring is configured

2020-09-22 Thread Liu, Changpeng
Hi Maxime, The code you wrote still need to check nr_vring is 0 or not, see the extra 2 lines added below, then it can work with my tests for now, could you submit a patch to DPDK to apply the patch? Thanks. BTW, dpdk vhost library still has an issue, it's not related with commit d0fcc38f, the

Re: [dpdk-dev] [PATCH] vhost: return ready when at least 1 vring is configured

2020-09-21 Thread Maxime Coquelin
On 9/21/20 7:03 AM, Liu, Changpeng wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Friday, September 18, 2020 5:54 PM >> To: Liu, Changpeng ; dev@dpdk.org >> Cc: ma...@mellanox.com; Xia, Chenbo ; Zawadzki, >> Tomasz >> Subject: Re: [PATCH] vhost: return r

Re: [dpdk-dev] [PATCH] vhost: return ready when at least 1 vring is configured

2020-09-20 Thread Liu, Changpeng
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Friday, September 18, 2020 5:54 PM > To: Liu, Changpeng ; dev@dpdk.org > Cc: ma...@mellanox.com; Xia, Chenbo ; Zawadzki, > Tomasz > Subject: Re: [PATCH] vhost: return ready when at least 1 vring is configured > > Hi Changpe

Re: [dpdk-dev] [PATCH] vhost: return ready when at least 1 vring is configured

2020-09-18 Thread Maxime Coquelin
Hi Changpeng, On 9/1/20 9:07 AM, Changpeng Liu wrote: > Commit d0fcc38f "vhost: improve device readiness notifications" > needs at least 2 vrings before changing the device state to > ready, this is fine for NET device but not correct for BLK > device. > > The number of vring required should be b

[dpdk-dev] [PATCH] vhost: return ready when at least 1 vring is configured

2020-08-31 Thread Changpeng Liu
Commit d0fcc38f "vhost: improve device readiness notifications" needs at least 2 vrings before changing the device state to ready, this is fine for NET device but not correct for BLK device. The number of vring required should be based on the device type, e.g. virtio_scsi device needs at least 3 v