Re: [dpdk-dev] [PATCH] vhost: optimize vhost memcpy

2016-12-06 Thread Wang, Zhihong
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > Sent: Monday, December 5, 2016 6:37 PM > To: Wang, Zhihong > Cc: dev@dpdk.org; Thomas Monjalon > Subject: Re: [PATCH] vhost: optimize vhost memcpy > > On Mon, Dec 05, 2016 at 10:27:00AM +, Wang, Zhihong

Re: [dpdk-dev] [PATCH] vhost: optimize vhost memcpy

2016-12-05 Thread Yuanhan Liu
On Mon, Dec 05, 2016 at 10:27:00AM +, Wang, Zhihong wrote: > > I like this function a lot, since it's really simple and straightforward! > > Moreover, it performs better. > > > > But, I don't quite like how this function is proposed: > > > > - rte_movX are more like internal help functions th

Re: [dpdk-dev] [PATCH] vhost: optimize vhost memcpy

2016-12-05 Thread Wang, Zhihong
> I like this function a lot, since it's really simple and straightforward! > Moreover, it performs better. > > But, I don't quite like how this function is proposed: > > - rte_movX are more like internal help functions that should be used only > in corresponding rte_memcpy.h file. > > - It's

Re: [dpdk-dev] [PATCH] vhost: optimize vhost memcpy

2016-12-05 Thread Yuanhan Liu
On Thu, Dec 01, 2016 at 08:19:42PM -0500, Zhihong Wang wrote: > This patch optimizes Vhost performance for large packets when the > Mergeable Rx buffer feature is enabled. It introduces a dedicated > memcpy function for vhost enqueue/dequeue to replace rte_memcpy. > > The reason is that rte_memcpy

Re: [dpdk-dev] [PATCH] vhost: optimize vhost memcpy

2016-12-02 Thread Thomas Monjalon
2016-12-01 20:19, Zhihong Wang: > Up to 20% gain can be achieved by this patch for PVP traffic. Really nice!

[dpdk-dev] [PATCH] vhost: optimize vhost memcpy

2016-12-02 Thread Zhihong Wang
This patch optimizes Vhost performance for large packets when the Mergeable Rx buffer feature is enabled. It introduces a dedicated memcpy function for vhost enqueue/dequeue to replace rte_memcpy. The reason is that rte_memcpy is for general cases, it handles unaligned copies and make store aligne