Re: [dpdk-dev] [PATCH] vhost: fix segfault as handle set_mem_table message

2018-03-29 Thread Wodkowski, PawelX
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Thursday, March 29, 2018 6:38 PM > To: Wodkowski, PawelX ; Tan, Jianfeng > ; Victor Kaplansky > Cc: dev@dpdk.org; sta...@dpdk.org; Yang, Yi Y ; > Harris, James R ; Yang, Ziye > ; Liu, Changpeng ; > Sto

Re: [dpdk-dev] [PATCH] vhost: fix segfault as handle set_mem_table message

2018-03-29 Thread Maxime Coquelin
Hi Pawel, On 03/29/2018 02:57 PM, Wodkowski, PawelX wrote: DPDK vhost-user handles this message rudely by unmap all existing regions and map new ones. This might lead to segfault if there is pmd thread just trying to touch those unmapped memory regions. But for most cases, except VM memory hotp

Re: [dpdk-dev] [PATCH] vhost: fix segfault as handle set_mem_table message

2018-03-29 Thread Tan, Jianfeng
On 3/29/2018 8:57 PM, Wodkowski, PawelX wrote: DPDK vhost-user handles this message rudely by unmap all existing regions and map new ones. This might lead to segfault if there is pmd thread just trying to touch those unmapped memory regions. But for most cases, except VM memory hotplug, FYI,

Re: [dpdk-dev] [PATCH] vhost: fix segfault as handle set_mem_table message

2018-03-29 Thread Tan, Jianfeng
On 3/29/2018 3:35 PM, Maxime Coquelin wrote: On 03/29/2018 09:01 AM, Tan, Jianfeng wrote: Hi Maxime and Victor, -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Tuesday, December 5, 2017 10:28 PM To: Yuanhan Liu; Tan, Jianfeng; Victor Kaplansky Cc:

Re: [dpdk-dev] [PATCH] vhost: fix segfault as handle set_mem_table message

2018-03-29 Thread Wodkowski, PawelX
> > DPDK vhost-user handles this message rudely by unmap all existing > > regions and map new ones. This might lead to segfault if there > > is pmd thread just trying to touch those unmapped memory regions. > > > > But for most cases, except VM memory hotplug, > >> > >> FYI, Vic

Re: [dpdk-dev] [PATCH] vhost: fix segfault as handle set_mem_table message

2018-03-29 Thread Maxime Coquelin
On 03/29/2018 09:01 AM, Tan, Jianfeng wrote: Hi Maxime and Victor, -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Tuesday, December 5, 2017 10:28 PM To: Yuanhan Liu; Tan, Jianfeng; Victor Kaplansky Cc: dev@dpdk.org; sta...@dpdk.org; Yang, Yi Y Subje

Re: [dpdk-dev] [PATCH] vhost: fix segfault as handle set_mem_table message

2018-03-29 Thread Tan, Jianfeng
Hi Maxime and Victor, > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Tuesday, December 5, 2017 10:28 PM > To: Yuanhan Liu; Tan, Jianfeng; Victor Kaplansky > Cc: dev@dpdk.org; sta...@dpdk.org; Yang, Yi Y > Subject: Re: [PATCH] vhost: fix segfault as

Re: [dpdk-dev] [PATCH] vhost: fix segfault as handle set_mem_table message

2017-12-05 Thread Maxime Coquelin
On 12/05/2017 03:19 PM, Yuanhan Liu wrote: On Tue, Nov 28, 2017 at 01:09:29PM +0100, Maxime Coquelin wrote: On 11/15/2017 12:41 PM, Jianfeng Tan wrote: In a running VM, operations (like device attach/detach) will trigger the QEMU to resend set_mem_table to vhost-user backend. DPDK vhost-us

Re: [dpdk-dev] [PATCH] vhost: fix segfault as handle set_mem_table message

2017-12-05 Thread Yuanhan Liu
On Tue, Nov 28, 2017 at 01:09:29PM +0100, Maxime Coquelin wrote: > > > On 11/15/2017 12:41 PM, Jianfeng Tan wrote: > >In a running VM, operations (like device attach/detach) will > >trigger the QEMU to resend set_mem_table to vhost-user backend. > > > >DPDK vhost-user handles this message rudely

Re: [dpdk-dev] [PATCH] vhost: fix segfault as handle set_mem_table message

2017-11-28 Thread Maxime Coquelin
On 11/15/2017 12:41 PM, Jianfeng Tan wrote: In a running VM, operations (like device attach/detach) will trigger the QEMU to resend set_mem_table to vhost-user backend. DPDK vhost-user handles this message rudely by unmap all existing regions and map new ones. This might lead to segfault if th

[dpdk-dev] [PATCH] vhost: fix segfault as handle set_mem_table message

2017-11-15 Thread Jianfeng Tan
In a running VM, operations (like device attach/detach) will trigger the QEMU to resend set_mem_table to vhost-user backend. DPDK vhost-user handles this message rudely by unmap all existing regions and map new ones. This might lead to segfault if there is pmd thread just trying to touch those unm