Re: [dpdk-dev] [PATCH] vhost: fix race condition in fdset_add

2018-12-18 Thread Maxime Coquelin
On 12/6/18 5:00 PM, Matthias Gatto wrote: fdset_add can call fdset_shrink_nolock which call fdset_move concurrently to poll that is call in fdset_event_dispatch. This patch add a mutex to protect poll from been call at the same time fdset_add call fdset_shrink_nolock. Signed-off-by: Matthias

Re: [dpdk-dev] [PATCH] vhost: fix race condition in fdset_add

2018-12-14 Thread Maxime Coquelin
On 12/14/18 11:07 AM, Matthias Gatto wrote: On Fri, Dec 14, 2018 at 10:53 AM Maxime Coquelin wrote: On 12/14/18 10:51 AM, Maxime Coquelin wrote: On 12/14/18 10:32 AM, Matthias Gatto wrote: On Tue, Dec 11, 2018 at 7:11 PM Maxime Coquelin wrote: Hi Matthias, On 12/6/18 5:00 PM, Matt

Re: [dpdk-dev] [PATCH] vhost: fix race condition in fdset_add

2018-12-14 Thread Matthias Gatto
On Fri, Dec 14, 2018 at 10:53 AM Maxime Coquelin wrote: > > > > On 12/14/18 10:51 AM, Maxime Coquelin wrote: > > > > > > On 12/14/18 10:32 AM, Matthias Gatto wrote: > >> On Tue, Dec 11, 2018 at 7:11 PM Maxime Coquelin > >> wrote: > >>> > >>> Hi Matthias, > >>> > >>> On 12/6/18 5:00 PM, Matthias G

Re: [dpdk-dev] [PATCH] vhost: fix race condition in fdset_add

2018-12-14 Thread Maxime Coquelin
On 12/14/18 10:51 AM, Maxime Coquelin wrote: On 12/14/18 10:32 AM, Matthias Gatto wrote: On Tue, Dec 11, 2018 at 7:11 PM Maxime Coquelin wrote: Hi Matthias, On 12/6/18 5:00 PM, Matthias Gatto wrote: fdset_add can call fdset_shrink_nolock which call fdset_move concurrently to poll that

Re: [dpdk-dev] [PATCH] vhost: fix race condition in fdset_add

2018-12-14 Thread Maxime Coquelin
On 12/14/18 10:32 AM, Matthias Gatto wrote: On Tue, Dec 11, 2018 at 7:11 PM Maxime Coquelin wrote: Hi Matthias, On 12/6/18 5:00 PM, Matthias Gatto wrote: fdset_add can call fdset_shrink_nolock which call fdset_move concurrently to poll that is call in fdset_event_dispatch. This patch add

Re: [dpdk-dev] [PATCH] vhost: fix race condition in fdset_add

2018-12-14 Thread Matthias Gatto
On Tue, Dec 11, 2018 at 7:11 PM Maxime Coquelin wrote: > > Hi Matthias, > > On 12/6/18 5:00 PM, Matthias Gatto wrote: > > fdset_add can call fdset_shrink_nolock which call fdset_move > > concurrently to poll that is call in fdset_event_dispatch. > > > > This patch add a mutex to protect poll from

Re: [dpdk-dev] [PATCH] vhost: fix race condition in fdset_add

2018-12-11 Thread Maxime Coquelin
Hi Matthias, On 12/6/18 5:00 PM, Matthias Gatto wrote: fdset_add can call fdset_shrink_nolock which call fdset_move concurrently to poll that is call in fdset_event_dispatch. This patch add a mutex to protect poll from been call at the same time fdset_add call fdset_shrink_nolock. Signed-off-b

[dpdk-dev] [PATCH] vhost: fix race condition in fdset_add

2018-12-06 Thread Matthias Gatto
fdset_add can call fdset_shrink_nolock which call fdset_move concurrently to poll that is call in fdset_event_dispatch. This patch add a mutex to protect poll from been call at the same time fdset_add call fdset_shrink_nolock. Signed-off-by: Matthias Gatto --- lib/librte_vhost/fd_man.c | 4