Re: [dpdk-dev] [PATCH] vhost: fix invalid use of stored last used index

2021-05-18 Thread Xia, Chenbo
> -Original Message- > From: dev On Behalf Of Balazs Nemeth > Sent: Saturday, May 15, 2021 12:02 AM > To: bnem...@redhat.com; dev@dpdk.org; Ling, WeiX > Subject: [dpdk-dev] [PATCH] vhost: fix invalid use of stored last used index > > The optimization introduced b

Re: [dpdk-dev] [PATCH] vhost: fix invalid use of stored last used index

2021-05-17 Thread Maxime Coquelin
On 5/17/21 12:07 PM, Ling, WeiX wrote: >> -Original Message- >> From: Maxime Coquelin >> Sent: Monday, May 17, 2021 03:38 PM >> To: Balazs Nemeth ; dev@dpdk.org; Ling, WeiX >> >> Subject: Re: [dpdk-dev] [PATCH] vhost: fix invalid use of sto

Re: [dpdk-dev] [PATCH] vhost: fix invalid use of stored last used index

2021-05-17 Thread Ling, WeiX
> -Original Message- > From: Maxime Coquelin > Sent: Monday, May 17, 2021 03:38 PM > To: Balazs Nemeth ; dev@dpdk.org; Ling, WeiX > > Subject: Re: [dpdk-dev] [PATCH] vhost: fix invalid use of stored last used > index > > Hi Ling, > > > On 5/14/21 6

Re: [dpdk-dev] [PATCH] vhost: fix invalid use of stored last used index

2021-05-17 Thread Maxime Coquelin
Hi Ling, On 5/14/21 6:02 PM, Balazs Nemeth wrote: > The optimization introduced by commit d18db8049c7c ("vhost: read last > used index once") didn't account for the fact that > vhost_flush_enqueue_shadow_packed increments the last_used_idx. For this > reason, store last_used_idx after the potenti

Re: [dpdk-dev] [PATCH] vhost: fix invalid use of stored last used index

2021-05-14 Thread David Marchand
On Fri, May 14, 2021 at 6:02 PM Balazs Nemeth wrote: > > The optimization introduced by commit d18db8049c7c ("vhost: read last > used index once") didn't account for the fact that > vhost_flush_enqueue_shadow_packed increments the last_used_idx. For this > reason, store last_used_idx after the pot

[dpdk-dev] [PATCH] vhost: fix invalid use of stored last used index

2021-05-14 Thread Balazs Nemeth
The optimization introduced by commit d18db8049c7c ("vhost: read last used index once") didn't account for the fact that vhost_flush_enqueue_shadow_packed increments the last_used_idx. For this reason, store last_used_idx after the potential call to vhost_flush_enqueue_shadow_packed. Fixes: d18db8