Re: [dpdk-dev] [PATCH] vhost: fix crash if set vring num handling failed

2018-09-03 Thread Ilya Maximets
On 03.09.2018 05:26, Tiwei Bie wrote: > On Thu, Aug 30, 2018 at 09:54:50AM +0300, Ilya Maximets wrote: >> On 30.08.2018 09:06, Tiwei Bie wrote: >>> On Wed, Aug 29, 2018 at 05:00:47PM +0300, Ilya Maximets wrote: Any thoughts on this? >>> >>> Hi Ilya, >>> >>> Currently, the errors happened durin

Re: [dpdk-dev] [PATCH] vhost: fix crash if set vring num handling failed

2018-09-02 Thread Tiwei Bie
On Thu, Aug 30, 2018 at 09:54:50AM +0300, Ilya Maximets wrote: > On 30.08.2018 09:06, Tiwei Bie wrote: > > On Wed, Aug 29, 2018 at 05:00:47PM +0300, Ilya Maximets wrote: > >> Any thoughts on this? > > > > Hi Ilya, > > > > Currently, the errors happened during messages handling > > aren't handled

Re: [dpdk-dev] [PATCH] vhost: fix crash if set vring num handling failed

2018-08-29 Thread Ilya Maximets
On 30.08.2018 09:06, Tiwei Bie wrote: > On Wed, Aug 29, 2018 at 05:00:47PM +0300, Ilya Maximets wrote: >> Any thoughts on this? > > Hi Ilya, > > Currently, the errors happened during messages handling > aren't handled properly. E.g. in vhost_user_set_mem_table(), > similar issues [1] may happen t

Re: [dpdk-dev] [PATCH] vhost: fix crash if set vring num handling failed

2018-08-29 Thread Tiwei Bie
On Wed, Aug 29, 2018 at 05:00:47PM +0300, Ilya Maximets wrote: > Any thoughts on this? Hi Ilya, Currently, the errors happened during messages handling aren't handled properly. E.g. in vhost_user_set_mem_table(), similar issues [1] may happen too. We might want to find a way to fix this once and

Re: [dpdk-dev] [PATCH] vhost: fix crash if set vring num handling failed

2018-08-29 Thread Ilya Maximets
Any thoughts on this? Best regards, Ilya Maximets. On 17.08.2018 14:33, Ilya Maximets wrote: > Allocation failures of shadow used ring and batched copy array > are not recoverable and leads to the segmentation faults like > this on the receiving/transmission path: > > Program received signal S

[dpdk-dev] [PATCH] vhost: fix crash if set vring num handling failed

2018-08-17 Thread Ilya Maximets
Allocation failures of shadow used ring and batched copy array are not recoverable and leads to the segmentation faults like this on the receiving/transmission path: Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7f913fecf0 (LWP 43625)] in copy_desc_to_mbuf () at