Re: [dpdk-dev] [PATCH] vhost: fix IPv4 csum calculation

2019-10-24 Thread Maxime Coquelin
On 10/24/19 6:31 PM, Flavio Leitner wrote: > On Thu, 24 Oct 2019 16:32:43 +0200 > Maxime Coquelin wrote: > >> Hi Flavio, >> >> On 10/24/19 4:28 PM, Flavio Leitner wrote: >>> Currently the IPv4 header checksum is calculated including its >>> current value, which can be a valid checksum or just

Re: [dpdk-dev] [PATCH] vhost: fix IPv4 csum calculation

2019-10-24 Thread Flavio Leitner
On Thu, 24 Oct 2019 16:32:43 +0200 Maxime Coquelin wrote: > Hi Flavio, > > On 10/24/19 4:28 PM, Flavio Leitner wrote: > > Currently the IPv4 header checksum is calculated including its > > current value, which can be a valid checksum or just garbage. > > In any case, if the original value is not

Re: [dpdk-dev] [PATCH] vhost: fix IPv4 csum calculation

2019-10-24 Thread Maxime Coquelin
Hi Flavio, On 10/24/19 4:28 PM, Flavio Leitner wrote: > Currently the IPv4 header checksum is calculated including its > current value, which can be a valid checksum or just garbage. > In any case, if the original value is not zero, then the result > is always wrong. > > The IPv4 checksum is defi

[dpdk-dev] [PATCH] vhost: fix IPv4 csum calculation

2019-10-24 Thread Flavio Leitner
Currently the IPv4 header checksum is calculated including its current value, which can be a valid checksum or just garbage. In any case, if the original value is not zero, then the result is always wrong. The IPv4 checksum is defined in RFC791, page 14 says: Header Checksum: 16 bits The che