Re: [dpdk-dev] [PATCH] vhost: change mbuf allocation logs to debug

2017-03-29 Thread Yuanhan Liu
On Wed, Mar 29, 2017 at 10:45:55PM +, Legacy, Allain wrote: > > -Original Message- > > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > > Sent: Wednesday, March 29, 2017 3:02 AM > > <...> > > > > OTOH, it's still good to have RTE_LOG_ONCE. It explicitly tells you > > somethin

Re: [dpdk-dev] [PATCH] vhost: change mbuf allocation logs to debug

2017-03-29 Thread Legacy, Allain
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > Sent: Wednesday, March 29, 2017 3:02 AM <...> > > OTOH, it's still good to have RTE_LOG_ONCE. It explicitly tells you something > is wrong, then you could dump those stats for more info. Has the implementatio

Re: [dpdk-dev] [PATCH] vhost: change mbuf allocation logs to debug

2017-03-29 Thread Yuanhan Liu
On Tue, Mar 28, 2017 at 11:39:37AM +, Legacy, Allain wrote: > > -Original Message- > > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > > Sent: Tuesday, March 28, 2017 2:49 AM > <...> > > > In order to prevent this condition, but > > > still enable debugging, the logs are being

Re: [dpdk-dev] [PATCH] vhost: change mbuf allocation logs to debug

2017-03-28 Thread Legacy, Allain
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > Sent: Tuesday, March 28, 2017 2:49 AM <...> > > In order to prevent this condition, but > > still enable debugging, the logs are being changed to debug logs to ensure > > they are not emitted unless the CONFIG_R

Re: [dpdk-dev] [PATCH] vhost: change mbuf allocation logs to debug

2017-03-27 Thread Yuanhan Liu
On Mon, Mar 27, 2017 at 12:29:30PM -0400, Allain Legacy wrote: > From: Matt Peters > > The current packet buffer alloc failures of the vhost dequeue operations > can flood the log system with error logs due to logging a runtime error > condition within the data path. I agree that we should avoid

[dpdk-dev] [PATCH] vhost: change mbuf allocation logs to debug

2017-03-27 Thread Allain Legacy
From: Matt Peters The current packet buffer alloc failures of the vhost dequeue operations can flood the log system with error logs due to logging a runtime error condition within the data path. In order to prevent this condition, but still enable debugging, the logs are being changed to debug l