Hi Neil
> I think what Thomas wants is for you to resend the patch with a proper
> changelog entry added to it, so the commit has an explination of what was
> changed and, for posterity.
Got it. Can I also incorporate your changes to error codes as well?
Best regards,
Anatoly Burakov
DPDK SW Eng
Hi Cristian,
> I would suggest we add a log message explaining which mechanism is loaded
> (igb_uio/vfio) and why (e.g. tried vfio first but container could not be
> opened, so falling back to igb_uio, etc).
This already happens.
If the container could not be loaded for whatever reason, the log
Behalf Of Burakov, Anatoly
Sent: Wednesday, June 18, 2014 9:57 AM
To: Thomas Monjalon
Cc: dev at dpdk.org
Subject: Re: [dpdk-dev] [PATCH] vfio: open VFIO container at startup rather
than during init
Hi Thomas,
> Subject: Re: [dpdk-dev] [PATCH] vfio: open VFIO container at startup rather
> than
Hi Thomas,
> Subject: Re: [dpdk-dev] [PATCH] vfio: open VFIO container at startup rather
> than during init
>
> > Signed-off-by: Anatoly Burakov
>
> Please Anatoly, could you provide a text explaining what was broken and
> why you fixed it this way?
What was broken
On Wed, Jun 18, 2014 at 11:02:23AM +, Burakov, Anatoly wrote:
> Hi Neil
>
> > I think what Thomas wants is for you to resend the patch with a proper
> > changelog entry added to it, so the commit has an explination of what was
> > changed and, for posterity.
>
> Got it. Can I also incorporate
On Wed, Jun 18, 2014 at 10:26:08AM +, Burakov, Anatoly wrote:
> Hi Cristian,
>
> > I would suggest we add a log message explaining which mechanism is loaded
> > (igb_uio/vfio) and why (e.g. tried vfio first but container could not be
> > opened, so falling back to igb_uio, etc).
>
> This alre
> Signed-off-by: Anatoly Burakov
Please Anatoly, could you provide a text explaining what was broken
and why you fixed it this way?
Thanks
--
Thomas
> -Original Message-
> From: Burakov, Anatoly
> Sent: Tuesday, June 17, 2014 2:12 AM
> To: dev at dpdk.org
> Cc: Richardson, Bruce
> Subject: [PATCH] vfio: open VFIO container at startup rather than during init
>
>
> Signed-off-by: Anatoly Burakov
> ---
This seems to fix the issue I w
Signed-off-by: Anatoly Burakov
---
lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
index 4de6061..9eb5dcd 100644
--- a/lib/libr
9 matches
Mail list logo