Re: [dpdk-dev] [PATCH] usertools: replace unsafe input function

2019-04-03 Thread Richardson, Bruce
> -Original Message- > From: Burakov, Anatoly > Sent: Wednesday, April 3, 2019 3:59 PM > To: Richardson, Bruce > Cc: Sirvys, Andrius ; dev@dpdk.org; Laatz, Kevin > ; sta...@dpdk.org; ciara.po...@intel.com > Subject: Re: [dpdk-dev] [PATCH] usertools: replace unsafe i

Re: [dpdk-dev] [PATCH] usertools: replace unsafe input function

2019-04-03 Thread Burakov, Anatoly
On 03-Apr-19 3:48 PM, Burakov, Anatoly wrote: On 03-Apr-19 3:29 PM, Burakov, Anatoly wrote: On 03-Apr-19 2:30 PM, Bruce Richardson wrote: On Wed, Apr 03, 2019 at 11:44:40AM +0100, Burakov, Anatoly wrote: On 20-Mar-19 4:43 PM, Andrius Sirvys wrote: LGTM static code analysis tool reports that t

Re: [dpdk-dev] [PATCH] usertools: replace unsafe input function

2019-04-03 Thread Burakov, Anatoly
On 03-Apr-19 3:29 PM, Burakov, Anatoly wrote: On 03-Apr-19 2:30 PM, Bruce Richardson wrote: On Wed, Apr 03, 2019 at 11:44:40AM +0100, Burakov, Anatoly wrote: On 20-Mar-19 4:43 PM, Andrius Sirvys wrote: LGTM static code analysis tool reports that the function 'input' is unsafe. Changed to use r

Re: [dpdk-dev] [PATCH] usertools: replace unsafe input function

2019-04-03 Thread Burakov, Anatoly
On 03-Apr-19 2:30 PM, Bruce Richardson wrote: On Wed, Apr 03, 2019 at 11:44:40AM +0100, Burakov, Anatoly wrote: On 20-Mar-19 4:43 PM, Andrius Sirvys wrote: LGTM static code analysis tool reports that the function 'input' is unsafe. Changed to use raw_input which then converts it using ast.liter

Re: [dpdk-dev] [PATCH] usertools: replace unsafe input function

2019-04-03 Thread Bruce Richardson
On Wed, Apr 03, 2019 at 11:44:40AM +0100, Burakov, Anatoly wrote: > On 20-Mar-19 4:43 PM, Andrius Sirvys wrote: > > LGTM static code analysis tool reports that the function 'input' is > > unsafe. Changed to use raw_input which then converts it using > > ast.literal_eval() which is safe. > > > > Fi

Re: [dpdk-dev] [PATCH] usertools: replace unsafe input function

2019-04-03 Thread Burakov, Anatoly
On 20-Mar-19 4:43 PM, Andrius Sirvys wrote: LGTM static code analysis tool reports that the function 'input' is unsafe. Changed to use raw_input which then converts it using ast.literal_eval() which is safe. Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry") Cc: ciara.po...@intel

Re: [dpdk-dev] [PATCH] usertools: replace unsafe input function

2019-04-03 Thread Laatz, Kevin
On 20/03/2019 16:43, Andrius Sirvys wrote: LGTM static code analysis tool reports that the function 'input' is unsafe. Changed to use raw_input which then converts it using ast.literal_eval() which is safe. Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry") Cc: ciara.po...@inte

[dpdk-dev] [PATCH] usertools: replace unsafe input function

2019-03-20 Thread Andrius Sirvys
LGTM static code analysis tool reports that the function 'input' is unsafe. Changed to use raw_input which then converts it using ast.literal_eval() which is safe. Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry") Cc: ciara.po...@intel.com Signed-off-by: Andrius Sirvys --- user