Re: [dpdk-dev] [PATCH] test/crypto: change cipher offset for esn vector

2020-07-15 Thread Akhil Goyal
> > > > > >> >Why do we need this change? > > > >> >The existing test case is to demonstrate a generic case where we > > > >> >can have an auth only trailer as well. It is similar to a case of > > > >> >IPSEC ESN but not exactly IPSec. Cipher offset can be anything as > > > >> >per the app > > > >r

Re: [dpdk-dev] [PATCH] test/crypto: change cipher offset for esn vector

2020-07-14 Thread Anoob Joseph
wal > ; Vakul Garg > Subject: Re: [dpdk-dev] [PATCH] test/crypto: change cipher offset for esn > vector > > Hi Akhil, > > Please see inline. > > Thanks, > Anoob > > > -Original Message- > > From: Akhil Goyal > > Sent: Wednesday, July 8, 2

Re: [dpdk-dev] [PATCH] test/crypto: change cipher offset for esn vector

2020-07-08 Thread Anoob Joseph
Hi Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Wednesday, July 8, 2020 12:51 AM > To: Ankur Dwivedi ; dev@dpdk.org > Cc: declan.dohe...@intel.com; Hemant Agrawal > ; Vakul Garg ; Anoob > Joseph > Subject: [EXT] RE: [PATCH] test/crypto: chan

Re: [dpdk-dev] [PATCH] test/crypto: change cipher offset for esn vector

2020-07-07 Thread Akhil Goyal
> >> >Why do we need this change? > >> >The existing test case is to demonstrate a generic case where we can > >> >have an auth only trailer as well. It is similar to a case of IPSEC > >> >ESN but not exactly IPSec. Cipher offset can be anything as per the app > >requirement. > >> >I don't think

Re: [dpdk-dev] [PATCH] test/crypto: change cipher offset for esn vector

2020-07-06 Thread Ankur Dwivedi
Hi Akhil, Please see my reply inline. Thanks Ankur >-Original Message- >From: Akhil Goyal >Sent: Tuesday, July 7, 2020 12:24 AM >To: Ankur Dwivedi ; dev@dpdk.org >Cc: declan.dohe...@intel.com; Hemant Agrawal >; Vakul Garg ; Anoob >Joseph >Subject: [EXT] RE: [PATCH] test/crypto: change

Re: [dpdk-dev] [PATCH] test/crypto: change cipher offset for esn vector

2020-07-06 Thread Akhil Goyal
> >Why do we need this change? > >The existing test case is to demonstrate a generic case where we can have an > >auth only trailer as well. It is similar to a case of IPSEC ESN but not > >exactly > >IPSec. Cipher offset can be anything as per the app requirement. > >I don't think there is anythin

Re: [dpdk-dev] [PATCH] test/crypto: change cipher offset for esn vector

2020-07-06 Thread Ankur Dwivedi
Hi Akhil, Please see my reply inline. Thanks Ankur >-Original Message- >From: Akhil Goyal >Sent: Monday, July 6, 2020 5:54 PM >To: Ankur Dwivedi ; dev@dpdk.org >Cc: declan.dohe...@intel.com; Hemant Agrawal >; Vakul Garg ; Anoob >Joseph >Subject: [EXT] RE: [PATCH] test/crypto: change ci

Re: [dpdk-dev] [PATCH] test/crypto: change cipher offset for esn vector

2020-07-06 Thread Akhil Goyal
Hi Ankur, > > In the IPSEC ESN test vector the cipher offset for encryption > should be 8 bytes which is the size of esp header. > This patch also changes the ciphertext and the digest reference > data against which the operaton result is validated. > > Fixes: 699741912d71 ("test/crypto: add case

Re: [dpdk-dev] [PATCH] test/crypto: change cipher offset for esn vector

2020-06-30 Thread Ankur Dwivedi
Hi All, Can you please review this patch? Thanks Ankur >-Original Message- >From: Ankur Dwivedi >Sent: Friday, June 5, 2020 2:01 PM >To: dev@dpdk.org >Cc: declan.dohe...@intel.com; akhil.go...@nxp.com; >hemant.agra...@nxp.com; vakul.g...@nxp.com; Anoob Joseph >; Ankur Dwivedi >Subject:

[dpdk-dev] [PATCH] test/crypto: change cipher offset for esn vector

2020-06-05 Thread Ankur Dwivedi
In the IPSEC ESN test vector the cipher offset for encryption should be 8 bytes which is the size of esp header. This patch also changes the ciphertext and the digest reference data against which the operaton result is validated. Fixes: 699741912d71 ("test/crypto: add case for auth only trailer")