Re: [dpdk-dev] [PATCH] service: fix shifts to operate on 64 bit integers

2017-07-31 Thread Van Haaren, Harry
> From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Monday, July 31, 2017 5:18 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] service: fix shifts to operate on 64 bit > integers > > Hi Harry, > > On Mon, Jul 31, 2017

Re: [dpdk-dev] [PATCH] service: fix shifts to operate on 64 bit integers

2017-07-31 Thread Gaëtan Rivet
Hi Harry, On Mon, Jul 31, 2017 at 04:58:27PM +0100, Harry van Haaren wrote: > This commit fixes shifts to an integer (1 << shift) which > is assumed to be a 32-bit integer. In this case, the shift is > variable and expected to be valid for 64-bit integers. Given that > the expectation to work with

[dpdk-dev] [PATCH] service: fix shifts to operate on 64 bit integers

2017-07-31 Thread Harry van Haaren
This commit fixes shifts to an integer (1 << shift) which is assumed to be a 32-bit integer. In this case, the shift is variable and expected to be valid for 64-bit integers. Given that the expectation to work with 64 bits exists, we must ensure that the (1 << shift) one in that formula is actually