Re: [dpdk-dev] [PATCH] reset src fd field to -1 in fdset_move of vhost

2018-01-21 Thread Zhao, Bing
On 2018/1/19 22:37, Yuanhan Liu wrote: On Thu, Dec 21, 2017 at 05:15:40PM +0800, Bing Zhao wrote: In the fdset_move, after copying the fd&rwfds from the src to the dst, the fd should be set to -1. Or else in some cases, there will be a fault missing. E.g: Before: 1 -1 3 4 -1 6 7 -1 9 10 After:

Re: [dpdk-dev] [PATCH] reset src fd field to -1 in fdset_move of vhost

2018-01-19 Thread Yuanhan Liu
On Thu, Dec 21, 2017 at 05:15:40PM +0800, Bing Zhao wrote: > In the fdset_move, after copying the fd&rwfds from the src to the dst, the fd > should be set to -1. Or else in some cases, there will be a fault missing. > E.g: > Before: 1 -1 3 4 -1 6 7 -1 9 10 > After: 1 10 3 4 9 6 7 -1 9 10 > Then t

[dpdk-dev] [PATCH] reset src fd field to -1 in fdset_move of vhost

2017-12-21 Thread Bing Zhao
In the fdset_move, after copying the fd&rwfds from the src to the dst, the fd should be set to -1. Or else in some cases, there will be a fault missing. E.g: Before: 1 -1 3 4 -1 6 7 -1 9 10 After: 1 10 3 4 9 6 7 -1 9 10 Then the index7 will be returned correctly for the first time, but if another