Re: [dpdk-dev] [PATCH] raw/ioat: fix queue index calculation

2020-11-04 Thread Bruce Richardson
On Tue, Nov 03, 2020 at 10:51:17PM +0100, Thomas Monjalon wrote: > 03/11/2020 21:21, Thomas Monjalon: > > 03/11/2020 15:48, Bruce Richardson: > > > Coverity flags a possible problem where the 8-bit wq_idx value may have > > > errors when shifted and sign-extended to 64-bits. Since this can only >

Re: [dpdk-dev] [PATCH] raw/ioat: fix queue index calculation

2020-11-03 Thread Thomas Monjalon
03/11/2020 21:21, Thomas Monjalon: > 03/11/2020 15:48, Bruce Richardson: > > Coverity flags a possible problem where the 8-bit wq_idx value may have > > errors when shifted and sign-extended to 64-bits. Since this can only occur > > if the shift index is larger than any expected value from hardware

Re: [dpdk-dev] [PATCH] raw/ioat: fix queue index calculation

2020-11-03 Thread Thomas Monjalon
03/11/2020 15:48, Bruce Richardson: > Coverity flags a possible problem where the 8-bit wq_idx value may have > errors when shifted and sign-extended to 64-bits. Since this can only occur > if the shift index is larger than any expected value from hardware, it's > unlikely to cause any real problem

[dpdk-dev] [PATCH] raw/ioat: fix queue index calculation

2020-11-03 Thread Bruce Richardson
Coverity flags a possible problem where the 8-bit wq_idx value may have errors when shifted and sign-extended to 64-bits. Since this can only occur if the shift index is larger than any expected value from hardware, it's unlikely to cause any real problems, but we can eliminate any possible errors,