Re: [dpdk-dev] [PATCH] ppc64le: fix build with Clang

2023-06-29 Thread Stephen Hemminger
On Thu, 14 Oct 2021 19:35:37 +0200 Piotr Kubaj wrote: > Couple of quite common issues: > 1. In rte_cycles.h, sys/platform/ppc.h and __ppc_get_timebase() are only for > glibc. > 2. In include/rte_atomic.h, the same issue already was encountered on arm64: > https://mails.dpdk.org/archives/dev/2019

Re: [dpdk-dev] [PATCH] ppc64le: fix build with Clang

2021-10-14 Thread Piotr Kubaj
The vector -> dpdk_vector renaming was done because there's a namespace pollution. vector is a keyword on ppc64le and that causes an error for clang. On 21-10-14 19:35:37, Piotr Kubaj wrote: > Couple of quite common issues: > 1. In rte_cycles.h, sys/platform/ppc.h and __ppc_get_timebase() are on

[dpdk-dev] [PATCH] ppc64le: fix build with Clang

2021-10-14 Thread Piotr Kubaj
Couple of quite common issues: 1. In rte_cycles.h, sys/platform/ppc.h and __ppc_get_timebase() are only for glibc. 2. In include/rte_atomic.h, the same issue already was encountered on arm64: https://mails.dpdk.org/archives/dev/2019-January/123331.html 3. In rte_altivec.h, defining vector to __vec

Re: [dpdk-dev] [PATCH] ppc64le: fix build with Clang

2021-10-14 Thread Chautru, Nicolas
Hi Piotr, See below, personally not okay with such a change. > -Original Message- > From: Piotr Kubaj > Sent: Thursday, October 14, 2021 10:36 AM > To: Chautru, Nicolas ; Doherty, Declan > ; Power, Ciara ; Xing, > Beilei ; Wang, Haiyue ; > jiawe...@trustnetic.com; jianw...@trustnetic.co

Re: [dpdk-dev] [PATCH] ppc64le: fix build with Clang and without glibc

2021-05-11 Thread David Marchand
On Sat, May 8, 2021 at 2:25 AM Piotr Kubaj wrote: > > Including below. > From 87ad59cc894b227444936fb6a7968932abdc460f Mon Sep 17 00:00:00 2001 > From: Piotr Kubaj > Date: Tue, 23 Mar 2021 00:40:47 +0100 > Subject: [PATCH] ppc64le: fix build without glibc > > __ppc_get_timebase() is only present

Re: [dpdk-dev] [PATCH] ppc64le: fix build with Clang and without glibc

2021-05-07 Thread David Christensen
On 5/5/21 3:39 PM, Piotr Kubaj wrote: lib/librte_eal/ppc/include/rte_altivec.h | 3 +++ lib/librte_eal/ppc/include/rte_cycles.h | 12 lib/librte_eal/ppc/rte_cycles.c | 16 Directory path "librte_eal" has been changed to "eal" so a v3 patch is like

Re: [dpdk-dev] [PATCH] ppc64le: fix build with Clang and without glibc

2021-05-07 Thread David Christensen
On 5/5/21 3:39 PM, Piotr Kubaj wrote: diff --git a/lib/librte_eal/ppc/include/rte_altivec.h b/lib/librte_eal/ppc/include/rte_altivec.h index 1551a9454..3fcc819c1 100644 --- a/lib/librte_eal/ppc/include/rte_altivec.h +++ b/lib/librte_eal/ppc/include/rte_altivec.h @@ -7,6 +7,9 @@ #define_RTE_

Re: [dpdk-dev] [PATCH] ppc64le: fix build with Clang and without glibc

2021-05-05 Thread David Marchand
On Tue, Mar 23, 2021 at 6:48 PM Piotr Kubaj wrote: > > Looks like I forgot to commit the change that includes headers for > sysctlbyname(). > > Patch attached. The mailing list drops attachments. Please submit a v2. Thanks. -- David Marchand

Re: [dpdk-dev] [PATCH] ppc64le: fix build with Clang and without glibc

2021-03-23 Thread Piotr Kubaj
Thank you for your input. I did not have Linux installed on my box previously and assumed __GLIBC__ is always defined when glibc i used. I just tested that this patch works on both Linux (Fedora 33) and FreeBSD (13.0-RC3 powerpc64le). On 21-03-15 12:48:19, David Christensen wrote: > > > On 3/1

Re: [dpdk-dev] [PATCH] ppc64le: fix build with Clang and without glibc

2021-03-23 Thread Piotr Kubaj
Looks like I forgot to commit the change that includes headers for sysctlbyname(). Patch attached. On 21-03-15 12:48:19, David Christensen wrote: > > > On 3/11/21 8:11 AM, Piotr Kubaj wrote: > > There are couple of issues when building with Clang: > > 1. vector is a keyword and should not be u

Re: [dpdk-dev] [PATCH] ppc64le: fix build with Clang and without glibc

2021-03-15 Thread David Christensen
On 3/11/21 8:11 AM, Piotr Kubaj wrote: There are couple of issues when building with Clang: 1. vector is a keyword and should not be used in code. I undefined it, but it would probably be better to just change the variable name. 2. vector long is deprecated by Clang and should not be used. I s

[dpdk-dev] [PATCH] ppc64le: fix build with Clang and without glibc

2021-03-14 Thread Piotr Kubaj
There are couple of issues when building with Clang: 1. vector is a keyword and should not be used in code. I undefined it, but it would probably be better to just change the variable name. 2. vector long is deprecated by Clang and should not be used. I switched here to vector int. 3. Additionally,

Re: [dpdk-dev] [PATCH] ppc64le: fix build with Clang and without glibc

2021-03-11 Thread Ajit Khaparde
On Thu, Mar 11, 2021 at 8:11 AM Piotr Kubaj wrote: > > There are couple of issues when building with Clang: > 1. vector is a keyword and should not be used in code. I undefined it, > but it would probably be better to just change the variable name. > 2. vector long is deprecated by Clang and shoul