Re: [dpdk-dev] [PATCH] pci: fix parsing of address without function number

2018-11-13 Thread Thomas Monjalon
12/11/2018 10:29, Gaëtan Rivet: > On Mon, Nov 12, 2018 at 12:58:56AM +0100, Thomas Monjalon wrote: > > If the last part of the PCI address (function number) is missing, > > the parsing was successful, assuming function 0. > > The call to strtoul is not returning an error in such a case, > > so an e

Re: [dpdk-dev] [PATCH] pci: fix parsing of address without function number

2018-11-12 Thread Gaëtan Rivet
On Mon, Nov 12, 2018 at 12:58:56AM +0100, Thomas Monjalon wrote: > If the last part of the PCI address (function number) is missing, > the parsing was successful, assuming function 0. > The call to strtoul is not returning an error in such a case, > so an explicit check is inserted before. > > Thi

[dpdk-dev] [PATCH] pci: fix parsing of address without function number

2018-11-11 Thread Thomas Monjalon
If the last part of the PCI address (function number) is missing, the parsing was successful, assuming function 0. The call to strtoul is not returning an error in such a case, so an explicit check is inserted before. This bug has always been there in older parsing macros: - GET_PCIADDR_FI