16/09/2013 14:42, Patrick Mahan :
> On Sep 16, 2013, at 1:29 PM, Thomas Monjalon
wrote:
> > There is no need to check for bars mapping, especially BAR0 is not
> > required. If bars mapping failed, then pci_uio_map_resource will fail and
> > we won't reach this check. So get rid of BAR0 check.
> >
> There is no need to check for bars mapping, especially BAR0 is not required.
> If bars mapping failed, then pci_uio_map_resource will fail and we won't
> reach this check. So get rid of BAR0 check.
> Besides, pci_uio_map_resource should only be called for Intel devices.
> The flag RTE_PCI_DRV_NEE
From: David Marchand
There is no need to check for bars mapping, especially BAR0 is not required.
If bars mapping failed, then pci_uio_map_resource will fail and we won't reach
this check. So get rid of BAR0 check.
Besides, pci_uio_map_resource should only be called for Intel devices.
The flag RT
I agree with Thomas, the check is not needed.
After this all settles out, I have a patch to add support for I/O
resource tracking in base DPDK. It makes it easier to do the right
thing in drivers that need to use I/O instead of memory.
I totally disagree with this statement. I am currently working on a non-intel
device that does need UIO support (I copied the igb UIO to create a new UIO
driver). This device not only needs bar0 but also bar1. I've modified the eal
PCI support code to support this behavior and change this beh
5 matches
Mail list logo
