Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-08 Thread Thomas Monjalon
2016-12-08 13:59, Wiles, Keith: > > > On Dec 8, 2016, at 3:30 AM, Nélio Laranjeiro > > wrote: > > > > Hi all, > > > > Following previous discussions, I would like to gather requirements for > > v2, currently we have: > > > > 1. Introduction of new typedefs. > > 2. Modification of network head

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-08 Thread Ananyev, Konstantin
> -Original Message- > From: Neil Horman [mailto:nhor...@tuxdriver.com] > Sent: Thursday, December 8, 2016 3:07 PM > To: Nélio Laranjeiro > Cc: dev@dpdk.org; Ananyev, Konstantin ; > Richardson, Bruce ; Wiles, > Keith ; Morten Brørup ; > Lu, Wenzhuo ; Olivier Matz > > Subject: Re: [PAT

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-08 Thread Neil Horman
On Thu, Dec 08, 2016 at 10:30:05AM +0100, Nélio Laranjeiro wrote: > Hi all, > > Following previous discussions, I would like to gather requirements for > v2, currently we have: > > 1. Introduction of new typedefs. > 2. Modification of network headers. > 3. Modification of rte_*_to_*() functions.

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-08 Thread Wiles, Keith
> On Dec 8, 2016, at 3:30 AM, Nélio Laranjeiro > wrote: > > Hi all, > > Following previous discussions, I would like to gather requirements for > v2, currently we have: > > 1. Introduction of new typedefs. > 2. Modification of network headers. > 3. Modification of rte_*_to_*() functions. > >

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-08 Thread Nélio Laranjeiro
Hi all, Following previous discussions, I would like to gather requirements for v2, currently we have: 1. Introduction of new typedefs. 2. Modification of network headers. 3. Modification of rte_*_to_*() functions. Point 1. seems not to be an issue, everyone seems to agree on the fact having tho

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Neil Horman
nanyev, Konstantin > > ; Richardson, Bruce > > ; dev@dpdk.org; Olivier Matz > > ; Lu, Wenzhuo ; Adrien > > Mazarguil > > Subject: Re: [dpdk-dev] [PATCH] net: introduce big and little endian types > > > > Hi all, > > > > On Tue, Dec 06, 2

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Ananyev, Konstantin
n > Mazarguil > Subject: Re: [dpdk-dev] [PATCH] net: introduce big and little endian types > > Hi all, > > On Tue, Dec 06, 2016 at 04:34:07PM +0100, Morten Brørup wrote: > > Hi all, > > > > Being a big fan of strong typing, I really like the concept of >

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Richardson, Bruce
> -Original Message- > From: Wiles, Keith > Sent: Tuesday, December 6, 2016 4:32 PM > To: Nélio Laranjeiro > Cc: Morten Brørup ; Ananyev, Konstantin > ; Richardson, Bruce > ; DPDK ; Olivier Matz > ; Lu, Wenzhuo ; Adrien > Mazarguil > Subject: Re: [dpdk-dev]

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Wiles, Keith
> On Dec 6, 2016, at 10:28 AM, Nélio Laranjeiro > wrote: > > Hi all, > > On Tue, Dec 06, 2016 at 04:34:07PM +0100, Morten Brørup wrote: >> Hi all, >> >> Being a big fan of strong typing, I really like the concept of >> explicit endian types. Especially if type mismatches can be caught at >> c

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Nélio Laranjeiro
Hi all, On Tue, Dec 06, 2016 at 04:34:07PM +0100, Morten Brørup wrote: > Hi all, > > Being a big fan of strong typing, I really like the concept of > explicit endian types. Especially if type mismatches can be caught at > compile time. +1, > However, I think it is too late! That train left the

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Morten Brørup
Hi all, Being a big fan of strong typing, I really like the concept of explicit endian types. Especially if type mismatches can be caught at compile time. However, I think it is too late! That train left the station when the rest of the world - including libraries and headers that might be link

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Wiles, Keith
gt;>> Sent: Tuesday, December 6, 2016 11:55 AM >>>> To: Ananyev, Konstantin >>>> Cc: Nélio Laranjeiro ; dev@dpdk.org; Olivier >>>> Matz ; Lu, Wenzhuo >>>> ; Adrien Mazarguil >>>> Subject: Re: [dpdk-dev] [PATCH] net: introduce big and lit

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Ananyev, Konstantin
; Cc: Nélio Laranjeiro ; dev@dpdk.org; Olivier > > > Matz ; Lu, Wenzhuo > > > ; Adrien Mazarguil > > > Subject: Re: [dpdk-dev] [PATCH] net: introduce big and little endian types > > > > > > On Tue, Dec 06, 2016 at 11:23:42AM +, Ananyev, Konstantin wrote

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Wiles, Keith
> On Dec 5, 2016, at 6:06 AM, Nélio Laranjeiro > wrote: > > On Mon, Dec 05, 2016 at 10:09:05AM +, Ananyev, Konstantin wrote: >> Hi Neilo, >> >>> >>> This commit introduces new rte_{le,be}{16,32,64}_t types and updates >>> rte_{le,be,cpu}_to_{le,be,cpu}_*() and network header structures >>

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Bruce Richardson
> > Matz ; Lu, Wenzhuo > > ; Adrien Mazarguil > > Subject: Re: [dpdk-dev] [PATCH] net: introduce big and little endian types > > > > On Tue, Dec 06, 2016 at 11:23:42AM +, Ananyev, Konstantin wrote: > > > Hi Neilo, > > > > > > > > >

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Bruce Richardson
On Tue, Dec 06, 2016 at 02:14:17PM +0100, Nélio Laranjeiro wrote: > Hi Konstantin, Bruce, > > On Tue, Dec 06, 2016 at 11:55:02AM +, Bruce Richardson wrote: > > On Tue, Dec 06, 2016 at 11:23:42AM +, Ananyev, Konstantin wrote: > > > Hi Neilo, > > > > > > > > > Hi Neilo, > > > > > > > > > >

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Nélio Laranjeiro
Hi Konstantin, Bruce, On Tue, Dec 06, 2016 at 11:55:02AM +, Bruce Richardson wrote: > On Tue, Dec 06, 2016 at 11:23:42AM +, Ananyev, Konstantin wrote: > > Hi Neilo, > > > > > > Hi Neilo, > > > > > > > > > > This commit introduces new rte_{le,be}{16,32,64}_t types and updates > > > > > rt

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Ananyev, Konstantin
> -Original Message- > From: Richardson, Bruce > Sent: Tuesday, December 6, 2016 11:55 AM > To: Ananyev, Konstantin > Cc: Nélio Laranjeiro ; dev@dpdk.org; Olivier Matz > ; Lu, Wenzhuo > ; Adrien Mazarguil > Subject: Re: [dpdk-dev] [PATCH] net: introduce big

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Bruce Richardson
On Tue, Dec 06, 2016 at 11:23:42AM +, Ananyev, Konstantin wrote: > Hi Neilo, > > > Hi Neilo, > > > > > > > > This commit introduces new rte_{le,be}{16,32,64}_t types and updates > > > > rte_{le,be,cpu}_to_{le,be,cpu}_*() and network header structures > > > > accordingly. > > > > > > > > Speci

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-06 Thread Ananyev, Konstantin
Hi Neilo, Hi Neilo, > > > > > > This commit introduces new rte_{le,be}{16,32,64}_t types and updates > > > rte_{le,be,cpu}_to_{le,be,cpu}_*() and network header structures > > > accordingly. > > > > > > Specific big/little endian types avoid uncertainty and conversion > > > mistakes. > > > > > >

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-05 Thread Nélio Laranjeiro
On Mon, Dec 05, 2016 at 10:09:05AM +, Ananyev, Konstantin wrote: > Hi Neilo, > > > > > This commit introduces new rte_{le,be}{16,32,64}_t types and updates > > rte_{le,be,cpu}_to_{le,be,cpu}_*() and network header structures > > accordingly. > > > > Specific big/little endian types avoid unc

Re: [dpdk-dev] [PATCH] net: introduce big and little endian types

2016-12-05 Thread Ananyev, Konstantin
Hi Neilo, > > This commit introduces new rte_{le,be}{16,32,64}_t types and updates > rte_{le,be,cpu}_to_{le,be,cpu}_*() and network header structures > accordingly. > > Specific big/little endian types avoid uncertainty and conversion mistakes. > > No ABI change since these are simply typedefs

[dpdk-dev] [PATCH] net: introduce big and little endian types

2016-11-09 Thread Nelio Laranjeiro
This commit introduces new rte_{le,be}{16,32,64}_t types and updates rte_{le,be,cpu}_to_{le,be,cpu}_*() and network header structures accordingly. Specific big/little endian types avoid uncertainty and conversion mistakes. No ABI change since these are simply typedefs to the original types. Sign