Re: [dpdk-dev] [PATCH] net/vmxnet3: convert to new rx offload api

2018-05-02 Thread Ferruh Yigit
On 5/1/2018 10:22 PM, Louis Luo wrote: > Ethdev RX offloads API has changed since: commit ce17eddefc20 > ("ethdev: introduce Rx queue offloads API") > > This patch adopts the new RX Offload API in vmxnet3 driver. > > Signed-off-by: Louis Luo > Acked-by: Yong Wang Applied to dpdk-next-net/maste

Re: [dpdk-dev] [PATCH] net/vmxnet3: convert to new rx offload api

2018-05-02 Thread Ferruh Yigit
On 5/1/2018 6:32 PM, Louis Luo wrote: > Hi Ferruh, > > Thanks for your review! Initially I did use PRIx64 there, but checkpatch.sh > always failed and complained about it for Camel case. So I just replaced it > with %lx. I will change it back and resend the review. Hi Louis, You are right chec

[dpdk-dev] [PATCH] net/vmxnet3: convert to new rx offload api

2018-05-01 Thread Louis Luo
Ethdev RX offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") This patch adopts the new RX Offload API in vmxnet3 driver. Signed-off-by: Louis Luo Acked-by: Yong Wang --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 61 ++--

Re: [dpdk-dev] [PATCH] net/vmxnet3: convert to new rx offload api

2018-05-01 Thread Thomas Monjalon
01/05/2018 20:10, Louis Luo: > Ethdev RX offloads API has changed since: commit ce17eddefc20 > ("ethdev: introduce Rx queue offloads API") > > This patch adopts the new RX Offload API in vmxnet3 driver. > > Signed-off-by: Louis Luo > > Acked-by: Yong Wang It looks to be a v2. Please use -v2 a

[dpdk-dev] [PATCH] net/vmxnet3: convert to new rx offload api

2018-05-01 Thread Louis Luo
Ethdev RX offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") This patch adopts the new RX Offload API in vmxnet3 driver. Signed-off-by: Louis Luo Acked-by: Yong Wang --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 61 ++--

Re: [dpdk-dev] [PATCH] net/vmxnet3: convert to new rx offload api

2018-05-01 Thread Louis Luo
Hi Ferruh, Thanks for your review! Initially I did use PRIx64 there, but checkpatch.sh always failed and complained about it for Camel case. So I just replaced it with %lx. I will change it back and resend the review. Thanks, Louis On 5/1/18, 7:58 AM, "Ferruh Yigit" wrote: On 4/30/2018

Re: [dpdk-dev] [PATCH] net/vmxnet3: convert to new rx offload api

2018-05-01 Thread Ferruh Yigit
On 4/30/2018 11:20 PM, Louis Luo wrote: > Ethdev RX offloads API has changed since: commit ce17eddefc20 > ("ethdev: introduce Rx queue offloads API") > > This patch adopts the new RX Offload API in vmxnet3 driver. > > Signed-off-by: Louis Luo Hi Louis, Overall patch looks good, only there is 32

Re: [dpdk-dev] [PATCH] net/vmxnet3: convert to new rx offload api

2018-04-30 Thread Yong Wang
> -Original Message- > From: Louis Luo [mailto:llo...@vmware.com] > Sent: Monday, April 30, 2018 3:21 PM > To: Yong Wang > Cc: dev@dpdk.org; Louis Luo > Subject: [PATCH] net/vmxnet3: convert to new rx offload api > > Ethdev RX offloads API has changed since: commit ce17eddefc20 > ("ethde

[dpdk-dev] [PATCH] net/vmxnet3: convert to new rx offload api

2018-04-30 Thread Louis Luo
Ethdev RX offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") This patch adopts the new RX Offload API in vmxnet3 driver. Signed-off-by: Louis Luo --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 61 ++-- 1 file changed, 45 i