Re: [dpdk-dev] [PATCH] net/virtio: fix mbuf data and pkt length mismatch

2019-10-15 Thread Andrew Rybchenko
Hi Tiwei, On 10/15/19 8:33 AM, Tiwei Bie wrote: On Mon, Oct 14, 2019 at 06:15:42PM +0300, Andrew Rybchenko wrote: diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index 27ead19fb..822cce06d 100644 --- a/drivers/net/virtio/virtio_rxtx.c +++ b/drivers/net/virtio/vi

Re: [dpdk-dev] [PATCH] net/virtio: fix mbuf data and pkt length mismatch

2019-10-14 Thread Tiwei Bie
On Mon, Oct 14, 2019 at 06:15:42PM +0300, Andrew Rybchenko wrote: > > diff --git a/drivers/net/virtio/virtio_rxtx.c > > b/drivers/net/virtio/virtio_rxtx.c > > index 27ead19fb..822cce06d 100644 > > --- a/drivers/net/virtio/virtio_rxtx.c > > +++ b/drivers/net/virtio/virtio_rxtx.c > > @@ -597,9 +597,

Re: [dpdk-dev] [PATCH] net/virtio: fix mbuf data and pkt length mismatch

2019-10-14 Thread Kevin Traynor
On 14/10/2019 16:15, Andrew Rybchenko wrote: > Hi, > > as far as I can see the patch introduces regressions. > > CC Kevin and Luca to be careful with stable branches patches. > Thanks Andrew. Just to confirm, it's not on any stable branches. Will note not to backport until it is resolved on mas

Re: [dpdk-dev] [PATCH] net/virtio: fix mbuf data and pkt length mismatch

2019-10-14 Thread Andrew Rybchenko
Hi, as far as I can see the patch introduces regressions. CC Kevin and Luca to be careful with stable branches patches. See details below. Andrew. On 9/23/19 5:05 PM, Marvin Liu wrote: If reserve virtio header room by function rte_pktmbuf_prepend, both segment data length and packet length o

Re: [dpdk-dev] [PATCH] net/virtio: fix mbuf data and pkt length mismatch

2019-10-07 Thread Andrew Rybchenko
On 9/27/19 12:50 PM, Maxime Coquelin wrote: On 9/23/19 4:05 PM, Marvin Liu wrote: If reserve virtio header room by function rte_pktmbuf_prepend, both segment data length and packet length of mbuf will be increased. Data length will be equal to descriptor length, while packet length should be dec

Re: [dpdk-dev] [PATCH] net/virtio: fix mbuf data and pkt length mismatch

2019-09-27 Thread Maxime Coquelin
On 9/23/19 4:05 PM, Marvin Liu wrote: > If reserve virtio header room by function rte_pktmbuf_prepend, both > segment data length and packet length of mbuf will be increased. > Data length will be equal to descriptor length, while packet length > should be decreased as virtio-net header won't be

Re: [dpdk-dev] [PATCH] net/virtio: fix mbuf data and pkt length mismatch

2019-09-27 Thread Maxime Coquelin
On 9/23/19 4:05 PM, Marvin Liu wrote: > If reserve virtio header room by function rte_pktmbuf_prepend, both > segment data length and packet length of mbuf will be increased. > Data length will be equal to descriptor length, while packet length > should be decreased as virtio-net header won't be

Re: [dpdk-dev] [PATCH] net/virtio: fix mbuf data and pkt length mismatch

2019-09-23 Thread Liu, Yong
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, September 23, 2019 11:22 PM > To: Liu, Yong > Cc: maxime.coque...@redhat.com; Bie, Tiwei ; Wang, > Zhihong ; dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH] net/virtio: fix mbuf data and

Re: [dpdk-dev] [PATCH] net/virtio: fix mbuf data and pkt length mismatch

2019-09-23 Thread Stephen Hemminger
On Mon, 23 Sep 2019 22:05:11 +0800 Marvin Liu wrote: > If reserve virtio header room by function rte_pktmbuf_prepend, both > segment data length and packet length of mbuf will be increased. > Data length will be equal to descriptor length, while packet length > should be decreased as virtio-net h

[dpdk-dev] [PATCH] net/virtio: fix mbuf data and pkt length mismatch

2019-09-22 Thread Marvin Liu
If reserve virtio header room by function rte_pktmbuf_prepend, both segment data length and packet length of mbuf will be increased. Data length will be equal to descriptor length, while packet length should be decreased as virtio-net header won't be taken into packet. Thus will cause mismatch in m