Re: [dpdk-dev] [PATCH] net/virtio: fix incorrect cast of void *

2017-12-27 Thread Yuanhan Liu
On Thu, Dec 14, 2017 at 03:49:32PM +0100, Maxime Coquelin wrote: > > > On 12/14/2017 03:33 PM, Olivier Matz wrote: > >From: Didier Pallard > > > >The rx_queues and tx_queues fields of the data structure points to a struct > >virtnet_rx or virtnet_tx. Casting it to a virtqueue is an error. > > >

Re: [dpdk-dev] [PATCH] net/virtio: fix incorrect cast of void *

2017-12-14 Thread Maxime Coquelin
On 12/14/2017 03:33 PM, Olivier Matz wrote: From: Didier Pallard The rx_queues and tx_queues fields of the data structure points to a struct virtnet_rx or virtnet_tx. Casting it to a virtqueue is an error. It does not trigger any bug because pointer is not dereferenced inside the function, b

[dpdk-dev] [PATCH] net/virtio: fix incorrect cast of void *

2017-12-14 Thread Olivier Matz
From: Didier Pallard The rx_queues and tx_queues fields of the data structure points to a struct virtnet_rx or virtnet_tx. Casting it to a virtqueue is an error. It does not trigger any bug because pointer is not dereferenced inside the function, but it can become a bug if this code is copy/past