> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Sunday, September 13, 2020 5:17 PM
> To: wangyunjian
> Cc: dev@dpdk.org; ferruh.yi...@intel.com; Lilijun (Jerry)
> ; xudingke ;
> keith.wi...@intel.com
> Subject: Re: [dpdk-dev] [PATC
> -Original Message-
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
> Sent: Wednesday, September 16, 2020 11:48 PM
> To: wangyunjian ; dev@dpdk.org
> Cc: tho...@monjalon.net; Lilijun (Jerry) ; xudingke
>
> Subject: Re: [dpdk-dev] [PATCH] net/tap: release port up
On 9/16/2020 8:20 AM, wangyunjian wrote:
-Original Message-
From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
Sent: Tuesday, September 15, 2020 10:53 PM
To: wangyunjian ; dev@dpdk.org
Cc: tho...@monjalon.net; Lilijun (Jerry) ; xudingke
Subject: Re: [dpdk-dev] [PATCH] net/tap: release
> -Original Message-
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
> Sent: Tuesday, September 15, 2020 10:53 PM
> To: wangyunjian ; dev@dpdk.org
> Cc: tho...@monjalon.net; Lilijun (Jerry) ; xudingke
>
> Subject: Re: [dpdk-dev] [PATCH] net/tap: release port up
On 8/28/2020 1:37 PM, wangyunjian wrote:
> From: Yunjian Wang
>
> Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private
> resources for the port can be freed by rte_eth_dev_close().
>
> Signed-off-by: Yunjian Wang
<...>
> @@ -1040,6 +1044,9 @@ tap_dev_close(struct rte_eth_dev *dev)
>
As you may notice, I have included a slightly modified version
of this patch in my series in order to cover the full picture:
https://patches.dpdk.org/patch/77566/
Feel free to continue improving your patch in this thread or the other,
as you prefer, as long as the secondary process issue
Hi,
28/08/2020 14:37, wangyunjian:
> @@ -1078,6 +1085,23 @@ tap_dev_close(struct rte_eth_dev *dev)
> +
> + /* mac_addrs must not be freed alone because part of dev_private */
> + dev->data->mac_addrs = NULL;
> +
> + internals = dev->data->dev_private;
> + TAP_LOG(DEBUG, "Closing %s
Please next time, use --cc-cmd devtools/get-maintainer.sh
so you will send it to Keith (Cc'ed) for review.
28/08/2020 14:37, wangyunjian:
> From: Yunjian Wang
>
> Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private
> resources for the port can be freed by rte_eth_dev_close().
>
> Signed
From: Yunjian Wang
Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private
resources for the port can be freed by rte_eth_dev_close().
Signed-off-by: Yunjian Wang
---
drivers/net/tap/rte_eth_tap.c | 42 ++-
1 file changed, 26 insertions(+), 16 deletions(-)
d
9 matches
Mail list logo