Re: [dpdk-dev] [PATCH] net/tap: fix missing _SC_IOV_MAX

2019-03-08 Thread Stephen Hemminger
On Fri, 8 Mar 2019 13:00:16 -0500 olegpoly123 wrote: > long iov_max = sysconf(_SC_IOV_MAX); > + > + if (iov_max <= 0) { > + TAP_LOG(WARNING, > + "_SC_IOV_MAX is not defined. Using %d as default\n", > TAP_IOV_DEFAULT_MAX); > + iov_max = TAP_I

Re: [dpdk-dev] [PATCH] net/tap: fix missing _SC_IOV_MAX

2019-03-08 Thread Thomas Monjalon
Thanks for contributing. Please find two comments below. > > On Mar 8, 2019, at 12:00 PM, olegpoly123 wrote: > > > > If the value _SC_IOV_MAX is missing, sysconf returns -1. > > In this case, iov_max is set to a default value of 1024. > > > > Cc: sta...@dpdk.org Is there any specific commit we

Re: [dpdk-dev] [PATCH] net/tap: fix missing _SC_IOV_MAX

2019-03-08 Thread Wiles, Keith
> On Mar 8, 2019, at 12:00 PM, olegpoly123 wrote: > > If the value _SC_IOV_MAX is missing, sysconf returns -1. > In this case, iov_max is set to a default value of 1024. > > Cc: sta...@dpdk.org > > Signed-off-by: olegpoly123 > --- > drivers/net/tap/rte_eth_tap.c | 8 > 1 file change

[dpdk-dev] [PATCH] net/tap: fix missing _SC_IOV_MAX

2019-03-08 Thread olegpoly123
If the value _SC_IOV_MAX is missing, sysconf returns -1. In this case, iov_max is set to a default value of 1024. Cc: sta...@dpdk.org Signed-off-by: olegpoly123 --- drivers/net/tap/rte_eth_tap.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/

[dpdk-dev] [PATCH] net/tap: fix missing _SC_IOV_MAX

2019-03-08 Thread olegpoly123
If the value _SC_IOV_MAX is missing, sysconf returns -1. In this case, iov_max is set to a default value of 1024. Cc: sta...@dpdk.org Signed-off-by: Oeg Polyakov --- drivers/net/tap/rte_eth_tap.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/ne

Re: [dpdk-dev] [PATCH] net/tap: fix missing _SC_IOV_MAX

2019-03-07 Thread Wiles, Keith
> On Mar 7, 2019, at 4:25 PM, olegpoly123 wrote: > > If the value _SC_IOV_MAX is missing, sysconf returns -1. > In this case, iov_max is set to a default value of 1024. > > Cc: sta...@dpdk.org > > Signed-off-by: Oeg Polyakov > --- > drivers/net/tap/rte_eth_tap.c | 5 + > 1 file changed,