Re: [dpdk-dev] [PATCH] net/tap: allow user MAC to be passed as args

dev@dpdk.org > Cc: Yigit, Ferruh ; Jain, Deepak K > > Subject: Re: [dpdk-dev] [PATCH] net/tap: allow user MAC to be passed as args > > Hi Pascal, > > Sincere apologizes, I think I missed out since rework was asked. Please find > my > answers inline to the comment >

Re: [dpdk-dev] [PATCH] net/tap: allow user MAC to be passed as args

Hi Pascal, Sincere apologizes, I think I missed out since rework was asked. Please find my answers inline to the comment > -Original Message- > From: Pascal Mazon [mailto:pascal.ma...@6wind.com] > Sent: Friday, February 2, 2018 9:16 AM > To: Varghese, Vipin ; dev@dpdk.org > Cc: Yigit, Fe

Re: [dpdk-dev] [PATCH] net/tap: allow user MAC to be passed as args

Hi, You didn't address my request about not using a global value. Was there a good reason? I paste it here again as a reminder: Can you also not use a global value for user_mac, but instead change the last argument for eth_dev_tap_create(): Use directly a char mac[ETHER_ADDR_LEN], automati

[dpdk-dev] [PATCH] net/tap: allow user MAC to be passed as args

Allow TAP PMD to pass user desired MAC address as argument. The argument value is processed as string, where each 2 bytes are converted to HEX MAC address after validation. Signed-off-by: Vipin Varghese --- doc/guides/nics/tap.rst | 6 + drivers/net/tap/rte_eth_tap.c | 62