Re: [dpdk-dev] [PATCH] net/mlx5: set RSS key len 0 to indicate default RSS

2018-10-29 Thread Ophir Munk
> -Original Message- > From: Shahaf Shuler > Sent: Sunday, October 07, 2018 2:21 PM > To: Yongseok Koh ; Ophir Munk > > Cc: dev@dpdk.org; Asaf Penso ; Thomas Monjalon > ; Olga Shern > Subject: RE: [PATCH] net/mlx5: set RSS key len 0 to indicate default RSS > > > > On Oct 3, 2018, at 10:3

Re: [dpdk-dev] [PATCH] net/mlx5: set RSS key len 0 to indicate default RSS

2018-10-29 Thread Ophir Munk
Please find comments inline. > -Original Message- > From: Yongseok Koh > Sent: Wednesday, October 03, 2018 9:56 PM > To: Ophir Munk > Cc: dev@dpdk.org; Asaf Penso ; Shahaf Shuler > ; Thomas Monjalon ; > Olga Shern > Subject: Re: [PATCH] net/mlx5: set RSS key len 0 to indicate default RSS

Re: [dpdk-dev] [PATCH] net/mlx5: set RSS key len 0 to indicate default RSS

2018-10-07 Thread Shahaf Shuler
Hi Ophir, To add on top of Koh's comment Wednesday, October 3, 2018 9:56 PM, Yongseok Koh: > Subject: Re: [PATCH] net/mlx5: set RSS key len 0 to indicate default RSS > > On Oct 3, 2018, at 10:37 AM, Ophir Munk > wrote: > > > > Applications which add an RSS flow must supply an RSS key table and a

Re: [dpdk-dev] [PATCH] net/mlx5: set RSS key len 0 to indicate default RSS

2018-10-03 Thread Yongseok Koh
> On Oct 3, 2018, at 10:37 AM, Ophir Munk wrote: > > Applications which add an RSS flow must supply an RSS key table and an > RSS key length. If an application needs to add the default RSS flow it > should not care about the exact RSS default key table and its length. > By setting key length to

[dpdk-dev] [PATCH] net/mlx5: set RSS key len 0 to indicate default RSS

2018-10-03 Thread Ophir Munk
Applications which add an RSS flow must supply an RSS key table and an RSS key length. If an application needs to add the default RSS flow it should not care about the exact RSS default key table and its length. By setting key length to 0 - the PMD will know that it should use the default RSS key t