Re: [dpdk-dev] [PATCH] net/mlx5: reduce txq completion index memory loads

2020-03-17 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Monday, March 16, 2020 5:35 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; Slava Ovsiienko ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: reduce txq completion index memory loads > > There is a non-optimal check

[dpdk-dev] [PATCH] net/mlx5: reduce txq completion index memory loads

2020-03-16 Thread Alexander Kozyrev
There is a non-optimal check if doorbel is needed present in the mlx5_tx_handle_completion() function. Advancing a copy of the txq consumer index and checking this copy with initial value causes unnecessary memory loads and hurts the performance. It is better to have a simple small boolean variable