Re: [dpdk-dev] [PATCH] net/mlx5: fix wrong segmented packet in Rx

Hi, Slava Thanks a lot for your correction and advice. I'm not very good at grammar 😁. Here is new patch and used your words.😃 https://patches.dpdk.org/project/dpdk/patch/1614619190-3846-1-git-send-email-17826875...@163.com/ With best regards, Jiawei On 2021/3/2 4:10 PM, Slava Ovsiienko wrot

Re: [dpdk-dev] [PATCH] net/mlx5: fix wrong segmented packet in Rx

Hi, Jiawei Thanks a lot for the update. There are some common points for the commit messages of fixing patches: - the bug/error/issue should be described in PAST tense (what we HAD before the fix) - what fix is doing should be described in PRESENT tense (what we HAVE right now, after fix apply)

Re: [dpdk-dev] [PATCH] net/mlx5: fix wrong segmented packet in Rx

Hi, Slava Thank you for your agreement. Here is the v2 patch: https://patches.dpdk.org/project/dpdk/patch/1614617885-2650-1-git-send-email-17826875...@163.com/ With best regards, Jiawei On 2021/3/1 5:13 PM, Slava Ovsiienko wrote: Hi, Jiawei Thank you for the clarification. I missed the point

Re: [dpdk-dev] [PATCH] net/mlx5: fix wrong segmented packet in Rx

Hi, Jiawei Thank you for the clarification. I missed the point that we have updated elts array with new allocated mbufs and are not able to retry packet building anymore. Very good catch, thank you! Could you, please, add this extra explanation to the commit message and send the v2 ? With bes

Re: [dpdk-dev] [PATCH] net/mlx5: fix wrong segmented packet in Rx

Hi, Slava Thanks for reading my patch, my issue may not be clear. Here I give a possible error. - we assume segs_n is 4 and we are receiving 4 segments multi-segment packet. - we fail to alloc mbuf when receive the 3th segment，so it will free the mbufs which packet chain we have built. Here are

Re: [dpdk-dev] [PATCH] net/mlx5: fix wrong segmented packet in Rx

Hi, Jiawei Thank you for the patch, but It seems I need some clarifications. As far I understand the issue: - we are in the midst of receiving the multi-segment packet - we have some mbufs allocated and packet chain is partially built - we fail on allocation replenishing mbuf for the segment - we

[dpdk-dev] [PATCH] net/mlx5: fix wrong segmented packet in Rx

Fixed issue could occur when Mbuf starvation happens in a middle of reception of a segmented packet. In such a situation, after release the segments of that packet, it does not align consumer index to the next stride. This would cause receive a wrong segmented packet. Fixes: 15a756b63734 ("net/mlx