Re: [dpdk-dev] [PATCH] net/mlx5: fix set VLAN vid size check

2020-05-04 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Wisam Monther > Sent: Thursday, April 30, 2020 11:31 AM > To: dev@dpdk.org; Dekel Peled ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: Moti Haimovsky ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix set VLAN vid size check > > All comparison should be do

Re: [dpdk-dev] [PATCH] net/mlx5: fix set VLAN vid size check

2020-04-30 Thread Slava Ovsiienko
> -Original Message- > From: Wisam Monther > Sent: Thursday, April 30, 2020 11:31 > To: dev@dpdk.org; Dekel Peled ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: Moti Haimovsky ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix set VLAN vid size check > > All comparison should be done in CP

[dpdk-dev] [PATCH] net/mlx5: fix set VLAN vid size check

2020-04-30 Thread Wisam Jaddo
All comparison should be done in CPU endianness, otherwise it will not give right results. for example: 255 after converting into RTE_BE16 will be biger than 4096 after converting into RTE_BE16. Fixes: a5f2da0b816b ("net/mlx5: support modify VLAN ID on new VLAN header") Cc: mo...@mellanox.com Cc: