Re: [dpdk-dev] [PATCH] net/mlx5: fix number of segment calculation

2017-11-11 Thread Ori Kam
Hi, Thanks Adrien and Yongseok for your review. Due to Adrien comment I'm withdrawing the patch. Thanks again, Ori Kam > -Original Message- > From: Yongseok Koh > Sent: Friday, November 10, 2017 11:23 PM > To: Adrien Mazarguil > Cc: Ori Kam ; Nélio Laranjeiro > ; dev@dpdk.org; sta...@

Re: [dpdk-dev] [PATCH] net/mlx5: fix number of segment calculation

2017-11-10 Thread Yongseok Koh
On Fri, Nov 10, 2017 at 11:22:06AM +0100, Adrien Mazarguil wrote: > Hi Yongseok, > > On Thu, Nov 09, 2017 at 02:30:30PM -0800, Yongseok Koh wrote: > > On Thu, Nov 09, 2017 at 06:04:32PM +0200, Ori Kam wrote: > > > The CRC size should be taken into consideration when computing > > > the number of m

Re: [dpdk-dev] [PATCH] net/mlx5: fix number of segment calculation

2017-11-10 Thread Yongseok Koh
On Fri, Nov 10, 2017 at 11:06:25AM +0100, Adrien Mazarguil wrote: > Hi Ori, > > On Thu, Nov 09, 2017 at 06:04:32PM +0200, Ori Kam wrote: > > The CRC size should be taken into consideration when computing > > the number of mbuf segments for packet on the receive path. > > Large packets can be dropp

Re: [dpdk-dev] [PATCH] net/mlx5: fix number of segment calculation

2017-11-10 Thread Adrien Mazarguil
Hi Yongseok, On Thu, Nov 09, 2017 at 02:30:30PM -0800, Yongseok Koh wrote: > On Thu, Nov 09, 2017 at 06:04:32PM +0200, Ori Kam wrote: > > The CRC size should be taken into consideration when computing > > the number of mbuf segments for packet on the receive path. > > Large packets can be dropped

Re: [dpdk-dev] [PATCH] net/mlx5: fix number of segment calculation

2017-11-10 Thread Adrien Mazarguil
Hi Ori, On Thu, Nov 09, 2017 at 06:04:32PM +0200, Ori Kam wrote: > The CRC size should be taken into consideration when computing > the number of mbuf segments for packet on the receive path. > Large packets can be dropped due to extra CRC length. > > Fixes: a1366b1a2be3 ("net/mlx5: add reference

Re: [dpdk-dev] [PATCH] net/mlx5: fix number of segment calculation

2017-11-09 Thread Yongseok Koh
On Thu, Nov 09, 2017 at 06:04:32PM +0200, Ori Kam wrote: > The CRC size should be taken into consideration when computing > the number of mbuf segments for packet on the receive path. > Large packets can be dropped due to extra CRC length. > > Fixes: a1366b1a2be3 ("net/mlx5: add reference counter

[dpdk-dev] [PATCH] net/mlx5: fix number of segment calculation

2017-11-09 Thread Ori Kam
The CRC size should be taken into consideration when computing the number of mbuf segments for packet on the receive path. Large packets can be dropped due to extra CRC length. Fixes: a1366b1a2be3 ("net/mlx5: add reference counter on DPDK Rx queues") Cc: sta...@dpdk.org Cc: nelio.laranje...@6wind.