Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset

2017-03-30 Thread Olivier Matz
Hi Wei, On Thu, 30 Mar 2017 10:46:45 +, "Dai, Wei" wrote: > HI, Olivier > > > > > Hi Wei, > > > > On Wed, 29 Mar 2017 09:22:55 +, "Dai, Wei" wrote: > > > First of all, I don't agree the method in this patch because the > > > register can also rewind to 0 in normal mode except reset/

Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset

2017-03-30 Thread Dai, Wei
HI, Olivier > > Hi Wei, > > On Wed, 29 Mar 2017 09:22:55 +, "Dai, Wei" wrote: > > First of all, I don't agree the method in this patch because the > > register can also rewind to 0 in normal mode except reset/PF down. > > > > In the function void ixgbe_down(struct ixgbe_adapter *adapter) of

Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset

2017-03-29 Thread Olivier Matz
Hi Wei, On Wed, 29 Mar 2017 09:22:55 +, "Dai, Wei" wrote: > First of all, I don't agree the method in this patch because the register can > also rewind to 0 in normal mode except > reset/PF down. > > In the function void ixgbe_down(struct ixgbe_adapter *adapter) of > ixgbe_main.c in the ix

Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset

2017-03-29 Thread Dai, Wei
Olivier Matz ; Dai, Wei > ; Guo Fengtian ; Yigit, Ferruh > > Subject: Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset > > Please ixgbe maintainers, what can be done for this fix? > > 2017-03-24 15:11, Olivier Matz: > > Hi, > > > > (remo

Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset

2017-03-29 Thread Dai, Wei
Olivier Matz ; Dai, Wei > ; Guo Fengtian ; Yigit, Ferruh > > Subject: Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset > > Please ixgbe maintainers, what can be done for this fix? > > 2017-03-24 15:11, Olivier Matz: > > Hi, > > > > (remo

Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset

2017-03-28 Thread Thomas Monjalon
; > > > > To: 'Olivier Matz' ; dev@dpdk.org; Zhang, > > > > > Helin ; Ananyev, Konstantin > > > > > > > > > > Cc: Guo Fengtian ; sta...@dpdk.org > > > > > Subject: RE: [dpdk-dev] [PATCH] net/ixgbevf: fix stats updat

Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset

2017-03-24 Thread Olivier Matz
t; -Original Message- > > > > From: Dai, Wei > > > > Sent: Thursday, February 9, 2017 10:38 PM > > > > To: 'Olivier Matz' ; dev@dpdk.org; Zhang, > > > > Helin ; Ananyev, Konstantin > > > > > > >

Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset

2017-03-14 Thread Olivier Matz
; To: 'Olivier Matz' ; dev@dpdk.org; Zhang, > > > Helin ; Ananyev, Konstantin > > > > > > Cc: Guo Fengtian ; sta...@dpdk.org > > > Subject: RE: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after > > > a PF reset > > > > > &g

Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset

2017-02-16 Thread Olivier Matz
> > Cc: Guo Fengtian ; sta...@dpdk.org > > Subject: RE: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after > > a PF reset > > > > The stats register can rewind to zero when the port is running for > > a long period. So I am afraid that this check is not al

Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset

2017-02-09 Thread Dai, Wei
yev, Konstantin > > Cc: Guo Fengtian ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset > > The stats register can rewind to zero when the port is running for a long > period. > So I am afraid that this check is not always co

Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset

2017-02-09 Thread Dai, Wei
v-boun...@dpdk.org] On Behalf Of Olivier Matz > Sent: Monday, February 6, 2017 9:59 PM > To: dev@dpdk.org; Zhang, Helin ; Ananyev, > Konstantin > Cc: Guo Fengtian ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset > > Hi, >

Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset

2017-02-06 Thread Olivier Matz
Hi, On Wed, 11 Jan 2017 18:04:14 +0100, Olivier Matz wrote: > From: Guo Fengtian > > When PF is set down, in VF, the value of stats register is zero. > So only increase stats when it's non zero. > > Fixes: af75078fece3 ("first public release") > > CC: sta...@dpdk.org > Signed-off-by: Guo Feng

[dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset

2017-01-11 Thread Olivier Matz
From: Guo Fengtian When PF is set down, in VF, the value of stats register is zero. So only increase stats when it's non zero. Fixes: af75078fece3 ("first public release") CC: sta...@dpdk.org Signed-off-by: Guo Fengtian Signed-off-by: Olivier Matz --- drivers/net/ixgbe/ixgbe_ethdev.c | 6 +++