Re: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+

2017-08-28 Thread Ferruh Yigit
, Wei >> Cc: Thomas Monjalon ; dev@dpdk.org; Lu, >> Wenzhuo ; Ananyev, Konstantin >> >> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot >> swapped SFP/SFP+ >> >> On 5/19/2017 11:04 AM, Srinivasan J wrote: >>> Hi Wei, >&

Re: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+

2017-07-18 Thread Dai, Wei
> Cc: Thomas Monjalon ; dev@dpdk.org; Lu, > Wenzhuo ; Ananyev, Konstantin > > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot > swapped SFP/SFP+ > > On 5/19/2017 11:04 AM, Srinivasan J wrote: > > Hi Wei, > > Yes the changes are in ixgbe

Re: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+

2017-06-29 Thread Ferruh Yigit
27;t call >> hw->phy.ops.init(hw) anywhere. >> >> Thanks & Best Regards >> -Wei >> >>> -Original Message- >>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon >>> Sent: Sunday, May 7, 2017 6:36 AM >>>

Re: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+

2017-05-19 Thread Srinivasan J
Thanks & Best Regards > -Wei > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon >> Sent: Sunday, May 7, 2017 6:36 AM >> To: Srinivasan J >> Cc: dev@dpdk.org; Lu, Wenzhuo ; Ananyev, >> Konstantin &

Re: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+

2017-05-15 Thread Dai, Wei
Of Thomas Monjalon > Sent: Sunday, May 7, 2017 6:36 AM > To: Srinivasan J > Cc: dev@dpdk.org; Lu, Wenzhuo ; Ananyev, > Konstantin > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot swapped > SFP/SFP+ > > 06/05/2017 15:51, Srinivasan J: > >

Re: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+

2017-05-06 Thread Thomas Monjalon
06/05/2017 15:51, Srinivasan J: > Hi, >Do we need an explicit "Acked-by" keyword for this > patch to be accepted and applied? Yes, given it is not a trivial patch, an ack from the maintainer is required. Anyway, it has been submitted too late for 17.05 testing.

Re: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+

2017-05-06 Thread Srinivasan J
Hi, Do we need an explicit "Acked-by" keyword for this patch to be accepted and applied? Thanks, Srini On Tue, Apr 25, 2017 at 6:53 AM, Lu, Wenzhuo wrote: > Hi Srini, > > >> -Original Message- >> From: Srinivasan J [mailto:srinid...@gmail.com] >> Sent: Monday, April 24

Re: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+

2017-04-24 Thread Lu, Wenzhuo
Hi Srini, > -Original Message- > From: Srinivasan J [mailto:srinid...@gmail.com] > Sent: Monday, April 24, 2017 6:51 PM > To: Lu, Wenzhuo > Cc: Ananyev, Konstantin; dev@dpdk.org > Subject: Re: [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+ > > Hi Wenzhuo, >

Re: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+

2017-04-24 Thread Srinivasan J
Hi Wenzhuo, Port hot-plug would require the DPDK app to dynamically mange ports and the kernel to support PCI hot-plugging. When multiple ports are detached/attached (SFP's plugged in/out), would the DPDK port id's remain same? If not, app needs to handle port id change for a gi

Re: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+

2017-04-24 Thread Lu, Wenzhuo
Hi Srini, > -Original Message- > From: Srinivasan J [mailto:srinid...@gmail.com] > Sent: Monday, April 24, 2017 2:24 PM > To: Lu, Wenzhuo > Cc: Ananyev, Konstantin; dev@dpdk.org > Subject: Re: [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+ > > Hi Wenzhuo, >

Re: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+

2017-04-23 Thread Srinivasan J
Hi Wenzhuo, I understand your concern. I had to do this change to support hot swap of SFP/SFP+ modules without restarting the DPDK app. If we have some other mechanism in pipeline to support hot swap of SFP/SFP+ modules, then my changes can be ignored. I just wanted to share the

Re: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+

2017-04-20 Thread Lu, Wenzhuo
Hi Srini, > -Original Message- > From: Srini J [mailto:srinid...@gmail.com] > Sent: Thursday, April 20, 2017 6:48 PM > To: Lu, Wenzhuo; Ananyev, Konstantin > Cc: dev@dpdk.org; Srinivasan Jayarajan > Subject: [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+ > > From: Srinivasan

[dpdk-dev] [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+

2017-04-20 Thread Srini J
From: Srinivasan Jayarajan Adds support to use a different SFP/SFP+ without restarting the DPDK app. rte_eth_dev_stop()/rte_eth_dev_start() will need to be called on the port to detect the SFP/SFP+ change. Signed-off-by: Srinivasan Jayarajan --- drivers/net/ixgbe/ixgbe_ethdev.c | 1