Re: [dpdk-dev] [PATCH] net/i40e: fix shifts of 32-bit value

2018-06-21 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Wednesday, May 23, 2018 3:47 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Guo, Jia > Subject: [PATCH] net/i40e: fix shifts of 32-bit value > > Cppcheck reports following error, > (error) Shifting 32-bit value by 36 bits is undefined behavi

Re: [dpdk-dev] [PATCH] net/i40e: fix shifts of 32-bit value

2018-05-23 Thread Ferruh Yigit
On 5/23/2018 8:46 AM, Beilei Xing wrote: > Cppcheck reports following error, > (error) Shifting 32-bit value by 36 bits is undefined behaviour > > According to datasheet, there's PHY type and PHY type extension > in setting PHY config command, should exclude PHY type extension > when setting PHY t

[dpdk-dev] [PATCH] net/i40e: fix shifts of 32-bit value

2018-05-23 Thread Beilei Xing
Cppcheck reports following error, (error) Shifting 32-bit value by 36 bits is undefined behaviour According to datasheet, there's PHY type and PHY type extension in setting PHY config command, should exclude PHY type extension when setting PHY type. Fixes: 1bb8f661168d ("net/i40e: fix link down a