Re: [dpdk-dev] [PATCH] net/i40e: fix register setting for hash enable

2021-01-28 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Xing, Beilei > Sent: Wednesday, January 27, 2021 11:08 AM > To: Yu, DapengX ; Guo, Jia > Cc: dev@dpdk.org; Yu, DapengX ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix register setti

Re: [dpdk-dev] [PATCH] net/i40e: fix register setting for hash enable

2021-01-26 Thread Xing, Beilei
> -Original Message- > From: dapengx...@intel.com > Sent: Tuesday, January 26, 2021 5:52 PM > To: Xing, Beilei ; Guo, Jia > Cc: dev@dpdk.org; Yu, DapengX ; sta...@dpdk.org > Subject: [PATCH] net/i40e: fix register setting for hash enable > > From: Dapeng Yu > > The original code cau

Re: [dpdk-dev] [PATCH] net/i40e: fix register setting for hash enable

2021-01-26 Thread Yu, DapengX
Hi Beilei, The pctype translation is introduced by i40e RSS refactor commit: ef4c16fd9148 by mistake, its behavior is inconsistent with the implementation before the refactor. This inconsistency can be gotten from the comparison of the running of the code. I have also confirmed with the autho

Re: [dpdk-dev] [PATCH] net/i40e: fix register setting for hash enable

2021-01-26 Thread Xing, Beilei
> -Original Message- > From: dapengx...@intel.com > Sent: Tuesday, January 26, 2021 5:52 PM > To: Xing, Beilei ; Guo, Jia > Cc: dev@dpdk.org; Yu, DapengX ; sta...@dpdk.org > Subject: [PATCH] net/i40e: fix register setting for hash enable > > From: Dapeng Yu > > The original code cau

[dpdk-dev] [PATCH] net/i40e: fix register setting for hash enable

2021-01-26 Thread dapengx . yu
From: Dapeng Yu The original code causes wrong value to be set into PFQF_HENA register because unnecessary calling to get translated pctype value for X722 NIC. The result is RSS cannot work. So remove the unnecessary translation. Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow") Cc: sta...@dp